Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Liu Ying <victor.liu@nxp.com>
To:     linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-arm-kernel@lists.infradead.org
Cc:     kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
        krzk+dt@kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org,
        robert.chiras@nxp.com, martin.kepplinger@puri.sm
Subject: [PATCH resend v8 2/5] phy: Add LVDS configuration options
Date:   Tue, 19 Apr 2022 09:08:49 +0800
Message-Id: <20220419010852.452169-3-victor.liu@nxp.com>
In-Reply-To: <20220419010852.452169-1-victor.liu@nxp.com>
References: <20220419010852.452169-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mdpiAyV7BO6TVzJ8AUCngKK92OL6vdd1J6qz59LCkHYCnxSUzHR8R9RL7hKL?=
 =?us-ascii?Q?9j3zJ55F+7quTHRG7d5J25mAayMsoZDSJxKEkm9tN8nAXMvx17xpPIal0cMc?=
 =?us-ascii?Q?KhX+ZV5CthCdaue1ml2fCqfx3kC0Pncsr42qNSkzw5eH6935BhBd1n7kusCm?=
 =?us-ascii?Q?djaneAfV5cBypHNNk+/deeHcg+KjjqWbOclGttKSLjcJe+G8M+f7vEpvScuX?=
 =?us-ascii?Q?HMRE1ekNb2Fdf56FT9BjDv9VTJ+jtu+8YQei/FjWlGevFbY54vsbuI+DHIig?=
 =?us-ascii?Q?DsvKiJ/B1KHFOBvoZoz1ReG2IFkeGmE0Jcb+xgNyK5UdMeTy/KDIbo1ayg5n?=
 =?us-ascii?Q?ivepsuLppb6nqhUECGYLSUxCaYPwArwbbQVSI34PM6CgEXRvZY1wiyb9H5eY?=
 =?us-ascii?Q?Idj305+WhjM+sJtqY2VnAAGy40vv82KRioDYqNr0R6MYZfnZDlpagQgE+dbj?=
 =?us-ascii?Q?pWjUuj1plfkxYrCF8pCzUOygfxGmMfBq4aKFj+DiCNWeoti9sSa+HVjwvZdV?=
 =?us-ascii?Q?UTZgCq1mTxW80tAPfZeKxvAl6ApODfC24bdlfD/xGtI7I69OF5uUcdSmar0u?=
 =?us-ascii?Q?qbyZgYkSbQ2DYG2MVRDJ/k3OP+NcilUyJT2xKrNpQ+laa2zSdSVZk5Yp99gW?=
 =?us-ascii?Q?4y2uC8PJj8WdH8Z8okoGDsZdrpV+StUJRPDdEnp+t2BOCmi0TbyOH3G9iVVr?=
 =?us-ascii?Q?L2LcGxuVdREhUGBqlGu9NmWz0YSPQghPeWchDm1V0zJTQ6YiqFt1KV4CzFNS?=
 =?us-ascii?Q?+0jbSHfHgqDfAgcP28G8EYYiPZSKseAcaPvy+0Wc8KlUs2JSpKWwr2eYN93r?=
 =?us-ascii?Q?DTTkCotNjyP295wSEaDE/21ojp0bY43yuxTJtijmqKMU+8BumrtRWmSWazfE?=
 =?us-ascii?Q?GhZKv/TEKMTMDHr44VIldxFUo51orI2dPN3U+8SjIX1OSXhCNm8C6GYAaknc?=
 =?us-ascii?Q?kk8ZX+lFFyMpdekq3DWzUDmh2kqI8z0vixSQd+gl9Xvi/qZZm4FXe8o3Cy9v?=
 =?us-ascii?Q?RjQNqtTsbhAplZKVgw3bx1gD+sYIc34tpN1sZGCVDu/wRvL1FZjDNdpEST+B?=
 =?us-ascii?Q?AwbECDTAq6dHmc6I1GPEhnGKr+lK22ERnftQpp6hQyZTENkddgx+xOtjNjGn?=
 =?us-ascii?Q?+ttZnrkeyecK/rZzhjIQ0VroZ5CYnvJ9bhQB+xweL/b7bjFqabRArk5QVjUA?=
 =?us-ascii?Q?ZLM4g+moBGsYS6rWplYjWb9yk5qFssf7zc3aKzRD7tptej0GsPMjmqfZhoyA?=
 =?us-ascii?Q?YXIrhmaWOmWz/TJiEy/ZHb3ql+SE5SfVEvew6Nfe3SW1sUWVJdawN9uPtRqG?=
 =?us-ascii?Q?Yjf4rNv4eQzyAmUMAlKdharqCM5YO2Se2JEIJectTqPh8i/mFXO5pQvnAvUM?=
 =?us-ascii?Q?Du81XZrebm6HN4ah3JIO0hf3ChqIEhzfuk77/4ZGWGsyyOJ2viIUQ9cXS3pS?=
 =?us-ascii?Q?sj7HkPILkk6xNom6xRr+SWYx/hO0DJFX68/9s3J8uIp7dyN/+XbGbxgbmGwg?=
 =?us-ascii?Q?TiYvQNtfIdfAE+LGidOznPty7oB3P/jmvw/QQrQ1J0YJJhlBGusuCYK6ARNQ?=
 =?us-ascii?Q?DPZsn7d0gDpzwYky9cTwT11pHcuWunXe6xfIvkupJABiHrNtWw576aN/p7gl?=
 =?us-ascii?Q?fvr455CysUhLCEsJCSM0TlP3ZvEFP6V/7L9y8SI+xWL1TReyTd93ycLtPGnt?=
 =?us-ascii?Q?Cmcnwlp9PWnoTvxNjVVgll8TO/dTFOGPHZwvPdu85RsaKlI2AOSyoBGnzX/f?=
 =?us-ascii?Q?XQzrKP+Wjw=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 382e2425-80bd-482b-d915-08da21a0f61a
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 01:07:23.6284
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: duWNk1GP3LcN+pSd2XYyk3E640VGcsT6mASYGcOjswO0HQBW41zsGbcpesGgd8BQVskmr6q935GfFxVwdedLFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3291
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This patch allows LVDS PHYs to be configured through
the generic functions and through a custom structure
added to the generic union.

The parameters added here are based on common LVDS PHY
implementation practices.  The set of parameters
should cover all potential users.

Cc: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: NXP Linux Team <linux-imx@nxp.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v7->v8:
* Trivial kernel doc style fix - add '*'.

v6->v7:
* Update the year of copyright.
* Better variable explanation for bits_per_lane_and_dclk_cycle.

v5->v6:
* Rebase upon v5.17-rc1.

v4->v5:
* Align kernel-doc style to include/linux/phy/phy.h. (Vinod)
* Trivial tweaks.
* Drop Robert's R-b tag.

v3->v4:
* Add Robert's R-b tag.

v2->v3:
* No change.

v1->v2:
* No change.

 include/linux/phy/phy-lvds.h | 32 ++++++++++++++++++++++++++++++++
 include/linux/phy/phy.h      |  4 ++++
 2 files changed, 36 insertions(+)
 create mode 100644 include/linux/phy/phy-lvds.h

diff --git a/include/linux/phy/phy-lvds.h b/include/linux/phy/phy-lvds.h
new file mode 100644
index 000000000000..09931d080a6d
--- /dev/null
+++ b/include/linux/phy/phy-lvds.h
@@ -0,0 +1,32 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright 2020,2022 NXP
+ */
+
+#ifndef __PHY_LVDS_H_
+#define __PHY_LVDS_H_
+
+/**
+ * struct phy_configure_opts_lvds - LVDS configuration set
+ * @bits_per_lane_and_dclk_cycle:	Number of bits per lane per differential
+ *					clock cycle.
+ * @differential_clk_rate:		Clock rate, in Hertz, of the LVDS
+ *					differential clock.
+ * @lanes:				Number of active, consecutive,
+ *					data lanes, starting from lane 0,
+ *					used for the transmissions.
+ * @is_slave:				Boolean, true if the phy is a slave
+ *					which works together with a master
+ *					phy to support dual link transmission,
+ *					otherwise a regular phy or a master phy.
+ *
+ * This structure is used to represent the configuration state of a LVDS phy.
+ */
+struct phy_configure_opts_lvds {
+	unsigned int	bits_per_lane_and_dclk_cycle;
+	unsigned long	differential_clk_rate;
+	unsigned int	lanes;
+	bool		is_slave;
+};
+
+#endif /* __PHY_LVDS_H_ */
diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h
index f3286f4cd306..b1413757fcc3 100644
--- a/include/linux/phy/phy.h
+++ b/include/linux/phy/phy.h
@@ -17,6 +17,7 @@
 #include <linux/regulator/consumer.h>
 
 #include <linux/phy/phy-dp.h>
+#include <linux/phy/phy-lvds.h>
 #include <linux/phy/phy-mipi-dphy.h>
 
 struct phy;
@@ -57,10 +58,13 @@ enum phy_media {
  *		the MIPI_DPHY phy mode.
  * @dp:		Configuration set applicable for phys supporting
  *		the DisplayPort protocol.
+ * @lvds:	Configuration set applicable for phys supporting
+ *		the LVDS phy mode.
  */
 union phy_configure_opts {
 	struct phy_configure_opts_mipi_dphy	mipi_dphy;
 	struct phy_configure_opts_dp		dp;
+	struct phy_configure_opts_lvds		lvds;
 };
 
 /**
-- 
2.25.1