Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Thu, 21 Apr 2022 11:39:25 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>
cc:     Miaoqian Lin <linmq006@gmail.com>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>,
        Alexandrov Stansilav <neko@nya.ai>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: elan: Fix potential double free in
 elan_input_configured
In-Reply-To: <CAO-hwJJyrPUdOm6JuzbE4Hi4pYi6hZDhf8zkJoczeOwj5jeaaA@mail.gmail.com>
Message-ID: <nycvar.YFH.7.76.2204211138450.30217@cbobk.fhfr.pm>
References: <20220416073721.3954-1-linmq006@gmail.com> <CAO-hwJJyrPUdOm6JuzbE4Hi4pYi6hZDhf8zkJoczeOwj5jeaaA@mail.gmail.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 21 Apr 2022, Benjamin Tissoires wrote:

> On Sat, Apr 16, 2022 at 9:37 AM Miaoqian Lin <linmq006@gmail.com> wrote:
> >
> > 'input' is a managed resource allocated with devm_input_allocate_device(),
> > so there is no need to call input_free_device() explicitly or
> > there will be a double free.
> >
> > According to the doc of devm_input_allocate_device():
> >  * Managed input devices do not need to be explicitly unregistered or
> >  * freed as it will be done automatically when owner device unbinds from
> >  * its driver (or binding fails).
> >
> > Fixes: b7429ea53d6c ("HID: elan: Fix memleak in elan_input_configured")
> > Fixes: 9a6a4193d65b ("HID: Add driver for USB ELAN Touchpad")
> > Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> 
> Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> 
> Thanks for the patch!

Hmm, this patch never seems to have reached my inbox, but we've had some 
trouble with our mailserver over the Easter weekend, so that could be it.

Thanks for the fix indeed, applied now to hid.git#for-5.18/upstream-fixes

-- 
Jiri Kosina
SUSE Labs