Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp767978pxb; Fri, 22 Apr 2022 10:43:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMkQ1/C54RwqbWEknd6hVvDeCK+deEXHEGxXmKsfgoyR46vgZgmK4vYXZ61vDze95VPknW X-Received: by 2002:a05:6a00:21c7:b0:4fd:f89f:ec17 with SMTP id t7-20020a056a0021c700b004fdf89fec17mr6197734pfj.72.1650649408983; Fri, 22 Apr 2022 10:43:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650649408; cv=none; d=google.com; s=arc-20160816; b=w/pCiTd5M9THPZU5rSeVVQZd4e4FivTCK7fI/AB86OSSuTK85TSl4T07RD2YfeHxnu Iz7ZrFu+4SsCeZx8VQRngKTT+6LdcI1wPTgMfpwSfQvHctCmxegI1EpN1HHgxD0D3hPr eJU5wjNnExcBJblovAgIkBaWPFk/4BYtVvr5+LsbCOYm5DZbaPn9i21DEDvUuJmJgERU YMGXepuqXRi3vyOSK7TdxLbpXpTyPgEFCh4sBBxlcj2kI3WXAjOAh8PKwC8BE0Lw5taI 0J/G27kXQcOTgBybhxI6JVTtsg1sJN8fsinufcQCYu+KXW2B0I8chT6uaSZf7c63mxZr G16A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=IStJTmSOIsrvA8AarDBP7blZFHlnItKhs1UbGilTXGY=; b=BQzldqZRyr3+x11CFnN+BRdPSHj+WVfyaUABtpcUd3UKzjNWINx9dKP0AopWDPz8ak mwFgrnGN8njvQY54Tvkxdapwm7jo0u+EUsOLoc8iQ8xocN3d4rWcicd3PPxmsTstFr5I TRugQrykNh51sNnZfgkCKEy7QpmURJJT2umrkujNbHeKLAdX/pDKoiC4zOjI9Q45Rr6p fxHanNdgPowtiztzP6tSWiC5G2UkSpX0vGT6tcWA2BPNF0Fe1Es1ELemttnfionoSsXc mpnQ2J31YwA2mjQ8vg98i3cUlQ9kPMSMRyDPPBW5VtdCTYZ8IdJpPMwloYGT4IWSmFgw 5+9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b5-20020a17090a488500b001cb68e59fd0si8240889pjh.88.2022.04.22.10.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:43:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1108DCD661; Fri, 22 Apr 2022 10:30:58 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387571AbiDUJX5 (ORCPT + 99 others); Thu, 21 Apr 2022 05:23:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387593AbiDUJXu (ORCPT ); Thu, 21 Apr 2022 05:23:50 -0400 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B2A524BE5 for ; Thu, 21 Apr 2022 02:20:54 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 21 Apr 2022 17:20:46 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Apr 2022 17:20:44 +0800 From: Haowen Bai To: Larry Finger , Phillip Potter , Greg Kroah-Hartman CC: Haowen Bai , , Subject: [PATCH] staging: r8188eu: Drop redundant memset Date: Thu, 21 Apr 2022 17:20:43 +0800 Message-ID: <1650532843-28132-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. So we drop redundant memset. Signed-off-by: Haowen Bai --- drivers/staging/r8188eu/os_dep/mlme_linux.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/r8188eu/os_dep/mlme_linux.c b/drivers/staging/r8188eu/os_dep/mlme_linux.c index 72ad9700130e..899d8e9c3834 100644 --- a/drivers/staging/r8188eu/os_dep/mlme_linux.c +++ b/drivers/staging/r8188eu/os_dep/mlme_linux.c @@ -66,7 +66,6 @@ void rtw_reset_securitypriv(struct adapter *adapter) /* We have to backup the PMK information for WiFi PMK Caching test item. */ /* Backup the btkip_countermeasure information. */ /* When the countermeasure is trigger, the driver have to disconnect with AP for 60 seconds. */ - memset(&backup_pmkid[0], 0x00, sizeof(struct rt_pmkid_list) * NUM_PMKID_CACHE); memcpy(&backup_pmkid[0], &adapter->securitypriv.PMKIDList[0], sizeof(struct rt_pmkid_list) * NUM_PMKID_CACHE); backup_index = adapter->securitypriv.PMKIDIndex; backup_counter = adapter->securitypriv.btkip_countermeasure; -- 2.7.4