Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp768605pxb; Fri, 22 Apr 2022 10:44:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyd0zaL77HQ5pCg2KPAYlTu/V8dWouzIG7ce3+TV/vOIJtJXYN3y0815s6HkuticJhdNsi5 X-Received: by 2002:a05:6a00:16cd:b0:4e1:366:7ee8 with SMTP id l13-20020a056a0016cd00b004e103667ee8mr6225039pfc.9.1650649456259; Fri, 22 Apr 2022 10:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650649456; cv=none; d=google.com; s=arc-20160816; b=oIf9FVjtkYLwQ4n0SxZD2B4CbssgM6z+lx5NBJ3P0SdNLSNxMUQc1JqUgBqXRfF3ho STT0N/EyDnFWTi+Au4PO3qZZkEe42V7bbPkPU3c8e6useehdrQ3PJxKXScz2YS4b+fER ybrzR4SKFuUin/kmi8qd5ZVuIue1WiiPPyTojmhaHVaE+B7PNrG+DbXRFJjfA2OwqISZ vQ6A7jTtlkG7USv6rN400oQxVZM/c0WGxulqp6ydyD+BrixOhZ2Iiov8BziQhX1m2u/D QhekY2sJJnsOyM/K4DSO7Nq3Ybimhh7Re4KiEcPrYAnsB71QctriT5Gxq1CSk6R8GUXh 69OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=3iZhtW6jmY/JZ4W04r03HnZWpoFk3B0F37/vrJx5Lg0=; b=bnptxhxaDJgYhdO8eigo26UszF8DDQMOcleXhiRoyBmQ+eidwgylSydlBd+nN1ztbM 6VYuvhlbVxpQxvIwyTvTZb7MhN9ZlHjpsGQDhi4rlyDBOSj2hWmUjnyErTqk6bVx29/7 lyaK/TlGuMpOhyNKFRw57SenmhrtWGCdFBTxyIwCenjyhjuCAwpl8PPnlSsCiVQpYZ8w js9jBhYooqznDm8ZH/681okuEa9vvf8A7sZX/dVV84W+m6g8EIzrMqjIbIPJ+Ac5EbKA dazckBlAmRflIis7OQaCFjsntX6AT2rVeHrqv9VJjJtQGVS1CCEoibsPM7BoDk71zsqC 2hnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id qe7-20020a17090b4f8700b001d8b655bbb1si1230602pjb.0.2022.04.22.10.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 09336B3C64; Fri, 22 Apr 2022 10:31:32 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444423AbiDVGdt (ORCPT + 99 others); Fri, 22 Apr 2022 02:33:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444416AbiDVGdq (ORCPT ); Fri, 22 Apr 2022 02:33:46 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32CF350B1F; Thu, 21 Apr 2022 23:30:51 -0700 (PDT) Received: from kwepemi500013.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Kl4KV5FGMzhY39; Fri, 22 Apr 2022 14:30:38 +0800 (CST) Received: from huawei.com (10.175.112.208) by kwepemi500013.china.huawei.com (7.221.188.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 22 Apr 2022 14:30:49 +0800 From: Zheng Yongjun To: , , CC: Subject: [PATCH] usb: dwc3: pci: Fix pm_runtime_get_sync() error checking Date: Fri, 22 Apr 2022 06:26:52 +0000 Message-ID: <20220422062652.10575-1-zhengyongjun3@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500013.china.huawei.com (7.221.188.120) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the device is already in a runtime PM enabled state pm_runtime_get_sync() will return 1, so a test for negative value should be used to check for errors. Fixes: 8eed00b237a28 ("usb: dwc3: pci: Runtime resume child device from wq") Signed-off-by: Zheng Yongjun --- drivers/usb/dwc3/dwc3-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 33f657d83246..491b5b05d196 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -286,7 +286,7 @@ static void dwc3_pci_resume_work(struct work_struct *work) int ret; ret = pm_runtime_get_sync(&dwc3->dev); - if (ret) { + if (ret < 0) { pm_runtime_put_sync_autosuspend(&dwc3->dev); return; } -- 2.17.1