Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp769036pxb; Fri, 22 Apr 2022 10:44:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzGo+QxJRCJZtuFRyw+q2bwQRFoGk2SYC5/WJZLePhOyDf7L1sHhM6gi7lTMasTtedT5Nwa X-Received: by 2002:a05:6a02:283:b0:342:703e:1434 with SMTP id bk3-20020a056a02028300b00342703e1434mr4847235pgb.74.1650649485074; Fri, 22 Apr 2022 10:44:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650649485; cv=none; d=google.com; s=arc-20160816; b=wKexSsIvOBiueuhmm0Xu78M9+j/MD1Ss4sFw4oidi6GwJ7Nph40m5B2y3++wyU4XZA skmuJ9xJMsPZmhiYb1B8n1bRqDw9Jhang6+Ky/+9eD2tNj4ki9tHB63gn9iwRPxU5jjC I0B0zZXM6yKTfmud0A97zY5c+X0bxUjGvh7pn6/HoUSmm3mQXVwY4UdyfuWQkW8AZ7hq 44p2hW54eqQCWt7uLEsY/btYkrmcVUNTHdeAaoNvSNhJMBFoLPrSSZNdNt1X7yV3GL+e KenXNGHJWXf0jfHjfMPRgZ4s+nzL+cDsrbWE6AMfuC7nxooLF4dJTKOdNlQKXxG1ZyA8 X8Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=5FUsF3Bm4YCkmboKOMo1H4UXrqyMZV42HmPdb6t+zEg=; b=UT+wvxudyi+EQCr+fCWS0aufa52FWqu/t/lq+WImL8ZIpncPUZSz0VubY33fGRak/q CFDwtE7Z/1p1jj53PcyUybgvizWq/xrRtoeVhV42asBmj9bjUJ+dncqoNuFQmOc/uO1g 62dzNbmVsArgpSuK57jLI3O+i5bOFRIRm9pux2wxRjJKsBbW6szHzgg3DzwM87G2UJsY q67viMWtw3uwd+tO4f4FmR0so4u114nDjvCED8quOrGcqSlUtiLM5w7TLAzCc8iS3k6T FlnIa7WPKEDbfrTDqpdUEQfLL79WlanbF238nUvEkEzQCCQhjYgolP29vrIrEmLHoISE DNKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTwMIkUl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id nn12-20020a17090b38cc00b001d03c08b551si8381565pjb.190.2022.04.22.10.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 10:44:45 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTwMIkUl; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0B819ECCCB; Fri, 22 Apr 2022 10:31:37 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446899AbiDVK42 (ORCPT + 99 others); Fri, 22 Apr 2022 06:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446889AbiDVK4Z (ORCPT ); Fri, 22 Apr 2022 06:56:25 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86D525549F for ; Fri, 22 Apr 2022 03:53:32 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id b24so9929408edu.10 for ; Fri, 22 Apr 2022 03:53:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5FUsF3Bm4YCkmboKOMo1H4UXrqyMZV42HmPdb6t+zEg=; b=iTwMIkUlm5QdnVZDvAMZ8lv3kIjxsQ9C28n0K6MiwbpwtvFce7ujI+BCC8Rv2gER9h a6684oc2VQwqV0D9gVE3quTVc776ypTodMrTG7mF+MNmMzk6nC3837htwDjcK3yrqYu1 9q1MwMpYT7T1YdAgi5q0/zzUWiT8eLkRI0a2K1W8Ejv5wlKP7UXZSA251z5qHmbCdIUw e+JScoyT03JamWyFX0UEHVaaoAaMI6ZZbck336N1e0YwfeUiFB5OSh0WdNoX73I4DbcH X45e5by65ELA6hXHR/qnfdriQvrl9tiFN41UWzC+94T5Pj8RgJqQ91XKCGUlBQ0b8gOl 0XSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5FUsF3Bm4YCkmboKOMo1H4UXrqyMZV42HmPdb6t+zEg=; b=E5jNEt8i4REHEpfknmH4RtnHcgLie5n8LyuWGi8TCd5rv/hLQGA0y3+hMh/F2RhXoG cwQeyGY3otm3jb0tuc6KhBU/zSVoSr1oKPrk8U/blx99CM3wUzS5/ABp1UJnm3OJrPz6 RMc8tRE9wHo3CjzFllujOIxHPj/tKyXuNuyCuiDkOwIMakJucQ31+mSnYw526UTsnXag df7HyTByCwj8lauznAY6OsyJh5HdE6oc2qbU2t5rE97YPp90JWJIaF2Y5pYa/bVNG/Fs kluloQ5K28k6Ycpsfs5G6FYmIGRUWJSt0mVa4IT+wfxes8Rf3QYDG+e0l8lnm+hELMHt qOqw== X-Gm-Message-State: AOAM530JP7OZ0+i/KP01VwiIMm3CY6/xqFB3QMcU91Q4FEfh+m8nomHH ll8i6SvAfgo9XMU5y0OtqZzkFw== X-Received: by 2002:a05:6402:50d0:b0:423:f4a1:597d with SMTP id h16-20020a05640250d000b00423f4a1597dmr4136984edb.228.1650624811158; Fri, 22 Apr 2022 03:53:31 -0700 (PDT) Received: from localhost.localdomain (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id lb26-20020a170907785a00b006ea4d2928e5sm625573ejc.218.2022.04.22.03.53.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 03:53:30 -0700 (PDT) From: Krzysztof Kozlowski To: Andy Gross , Bjorn Andersson , Mathieu Poirier , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH] rpmsg: qcom_smd: Fix irq_of_parse_and_map() return value Date: Fri, 22 Apr 2022 12:53:26 +0200 Message-Id: <20220422105326.78713-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend") Signed-off-by: Krzysztof Kozlowski --- drivers/rpmsg/qcom_smd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c index 764c980507be..6ccfa12abd10 100644 --- a/drivers/rpmsg/qcom_smd.c +++ b/drivers/rpmsg/qcom_smd.c @@ -1407,7 +1407,7 @@ static int qcom_smd_parse_edge(struct device *dev, edge->name = node->name; irq = irq_of_parse_and_map(node, 0); - if (irq < 0) { + if (!irq) { dev_err(dev, "required smd interrupt missing\n"); ret = irq; goto put_node; -- 2.32.0