Subject: Re: [PATCH 1/2] Use common cpu_is_xxx() macros on AT91 and AVR32
From: Andrew Victor <andrew@sanpeople.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: akpm@linux-foundation.org, David Brownell <david-b@pacbell.net>,
       Nicolas Ferre <nicolas.ferre@rfo.atmel.com>,
       linux-kernel@vger.kernel.org
In-Reply-To: <11785276841920-git-send-email-hskinnemoen@atmel.com>
References: <11785276841920-git-send-email-hskinnemoen@atmel.com>
Content-Type: text/plain
Organization: Multenet Technologies (Pty) Ltd
Message-Id: <1178534593.27286.28.camel@fuzzie.sanpeople.com>
Mime-Version: 1.0
Date: 07 May 2007 12:43:13 +0200
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 867
Lines: 21


> Several drivers shared between AT91 and AVR32 chips use cpu_is_xxx()
> to handle CPU-specific differences. Currently, such code needs to be
> inside #ifdef CONFIG_ARCH_AT91 because the macros don't exist on AVR32.
> 
> By defining the same macros on both AT91 and AVR32, these #ifdefs can
> be eliminated. Since the macros will evaluate to a constant value for
> CPUs that aren't supported by the current architecture, any code that
> is only needed on AT91 will be optimized away on AVR32 and vice versa.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>

Acked-by: Andrew Victor <andrew@sanpeople.com>


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/