Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933041AbXEGLWz (ORCPT ); Mon, 7 May 2007 07:22:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933099AbXEGLWy (ORCPT ); Mon, 7 May 2007 07:22:54 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:1298 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933041AbXEGLWx (ORCPT ); Mon, 7 May 2007 07:22:53 -0400 Date: Mon, 7 May 2007 13:22:40 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Krzysztof Halasa cc: Jeff Garzik , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 21 Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel writes: > > > What's the advantage? The HDLC option is directly before this? > > You don't have to know it's required, you can just select a driver > for your hardware, without enabling HDLC first. Is this a real problem? Using select you should also consider removing HDLC as visible option and use only select. Mixing depends and selects is generally a bad idea. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/