Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <62e9ece1-5d71-f803-3f65-2755160cf1d1@redhat.com>
Date:   Thu, 21 Apr 2022 17:56:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To:     Peter Gonda <pgonda@google.com>,
        John Sperbeck <jsperbeck@google.com>
Cc:     kvm list <kvm@vger.kernel.org>,
        David Rientjes <rientjes@google.com>,
        Sean Christopherson <seanjc@google.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20220407195908.633003-1-pgonda@google.com>
 <CAFNjLiXC0AdOw5f8Ovu47D==ex7F0=WN_Ocirymz4xL=mWvC5A@mail.gmail.com>
 <CAMkAt6r-Mc_YN-gVHuCpTj4E1EmcvyYpP9jhtHo5HRHnoNJAdA@mail.gmail.com>
 <CAMkAt6r+OMPWCbV_svUyGWa0qMzjj2UEG29G6P7jb6uH6yko2w@mail.gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v3] KVM: SEV: Mark nested locking of vcpu->lock
In-Reply-To: <CAMkAt6r+OMPWCbV_svUyGWa0qMzjj2UEG29G6P7jb6uH6yko2w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 4/20/22 22:14, Peter Gonda wrote:
>>>> svm_vm_migrate_from() uses sev_lock_vcpus_for_migration() to lock all
>>>> source and target vcpu->locks. Mark the nested subclasses to avoid false
>>>> positives from lockdep.
>> Nope. Good catch, I didn't realize there was a limit 8 subclasses:
> Does anyone have thoughts on how we can resolve this vCPU locking with
> the 8 subclass max?

The documentation does not have anything.  Maybe you can call 
mutex_release manually (and mutex_acquire before unlocking).

Paolo