Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 21 Apr 2022 11:54:03 -0700
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Steven Rostedt <rostedt@goodmis.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     YueHaibing <yuehaibing@huawei.com>, mingo@redhat.com,
        xiaowei66@huawei.com, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH sysctl-next] ftrace: fix building with SYSCTL=n but
 DYNAMIC_FTRACE=y
Message-ID: <YmGoS+5Ixaud2xkO@bombadil.infradead.org>
References: <YlnpfHuZGC8H0iNZ@bombadil.infradead.org>
 <20220420192807.75a70b44@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220420192807.75a70b44@gandalf.local.home>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Wed, Apr 20, 2022 at 07:28:07PM -0400, Steven Rostedt wrote:
> On Fri, 15 Apr 2022 14:54:04 -0700
> Luis Chamberlain <mcgrof@kernel.org> wrote:
> 
> > Steven,
> > 
> > As with the other fixes I can take this in through sysctl-next if you
> > are OK with that, please let me know.
> 
> Honestly I would love to just nuke the ftrace_enabled sysctl, it's totally
> obsolete. Perhaps I should have it trigger some kind of warning message
> that it will be going away soon, and perhaps we can remove it?

I'm not sure if we can remove proc sysctls, that can break userpace
interaction. But deprecating it.. yeah I think it's fine to strive
for it, and just make the code do at least what it used to. In fact
sadly I don't see this documented well, we do have the documentation in
Documentation/admin-guide/sysctl/ but we don't really spell it out if
we can nuke some. Eric, do you have any thoughts on eventually
*removing* sysctls? Maybe we should document this.

BTW yeah another thing I noticed while looking at ftrace.c file was it could
probably use some spring cleaning by splitting the file up into multiple
files. Hey I'm not volunteering :) just an idea.

> Anyway, yeah, take this through your tree.

OK thanks, 0day found one last issue, I'll send a patch for that just
now. Let me know if you're OK for me to just squash that into this
patch.

> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>

  Luis