Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 20 Apr 2022 15:22:41 +0200
From:   Claudio Imbrenda <imbrenda@linux.ibm.com>
To:     Heiko Carstens <hca@linux.ibm.com>
Cc:     Pierre Morel <pmorel@linux.ibm.com>, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        borntraeger@de.ibm.com, frankja@linux.ibm.com, cohuck@redhat.com,
        david@redhat.com, thuth@redhat.com, gor@linux.ibm.com,
        wintera@linux.ibm.com, seiden@linux.ibm.com, nrb@linux.ibm.com
Subject: Re: [PATCH v8 1/2] s390x: KVM: guest support for topology function
Message-ID: <20220420152241.4d9edea5@p-imbrenda>
In-Reply-To: <Yl/27Pz3pvARmIHn@osiris>
References: <20220420113430.11876-1-pmorel@linux.ibm.com>
        <20220420113430.11876-2-pmorel@linux.ibm.com>
        <Yl/27Pz3pvARmIHn@osiris>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 20 Apr 2022 14:05:00 +0200
Heiko Carstens <hca@linux.ibm.com> wrote:

> > +static inline bool kvm_s390_topology_changed(struct kvm_vcpu *vcpu)
> > +{
> > +	if (!test_kvm_facility(vcpu->kvm, 11))
> > +		return false;
> > +
> > +	/* A new vCPU has been hotplugged */
> > +	if (vcpu->arch.prev_cpu == S390_KVM_TOPOLOGY_NEW_CPU)
> > +		return true;
> > +
> > +	/* The real CPU backing up the vCPU moved to another socket */
> > +	if (cpumask_test_cpu(vcpu->cpu,
> > +			     topology_core_cpumask(vcpu->arch.prev_cpu)))
> > +		return true;
> > +
> > +	return false;
> > +}  
> 
> This seems to be wrong. I'd guess that you need
> 
> 	if (cpumask_test_cpu(vcpu->cpu,
> 			     topology_core_cpumask(vcpu->arch.prev_cpu)))
> -->		return false;
> -->	return true;  

so if the CPU moved to a different socket, it's not a change?
and if nothing happened, it is a change?