Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Sender: Corey Minyard <tcminyard@gmail.com>
Date:   Thu, 21 Apr 2022 11:05:21 -0500
From:   Corey Minyard <minyard@acm.org>
To:     Yu Zhe <yuzhe@nfschina.com>
Cc:     openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        liqiong@nfschina.com
Subject: Re: [PATCH] ipmi: remove unnecessary type castings
Message-ID: <20220421160521.GB426325@minyard.net>
Reply-To: minyard@acm.org
References: <20220421150941.7659-1-yuzhe@nfschina.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220421150941.7659-1-yuzhe@nfschina.com>
Precedence: bulk

On Thu, Apr 21, 2022 at 08:09:41AM -0700, Yu Zhe wrote:
> remove unnecessary void* type castings.

Thanks, queued for next release.

-corey

> 
> Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 6 +++---
>  drivers/char/ipmi/ipmi_ssif.c       | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index c59265146e9c..6e6aee19c39d 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -2296,7 +2296,7 @@ static int i_ipmi_request(struct ipmi_user     *user,
>  	recv_msg->user_msg_data = user_msg_data;
>  
>  	if (supplied_smi)
> -		smi_msg = (struct ipmi_smi_msg *) supplied_smi;
> +		smi_msg = supplied_smi;
>  	else {
>  		smi_msg = ipmi_alloc_smi_msg();
>  		if (smi_msg == NULL) {
> @@ -3989,7 +3989,7 @@ static int handle_ipmb_direct_rcv_rsp(struct ipmi_smi *intf,
>  	struct ipmi_recv_msg *recv_msg;
>  	struct ipmi_ipmb_direct_addr *daddr;
>  
> -	recv_msg = (struct ipmi_recv_msg *) msg->user_data;
> +	recv_msg = msg->user_data;
>  	if (recv_msg == NULL) {
>  		dev_warn(intf->si_dev,
>  			 "IPMI message received with no owner. This could be because of a malformed message, or because of a hardware error.  Contact your hardware vendor for assistance.\n");
> @@ -4407,7 +4407,7 @@ static int handle_bmc_rsp(struct ipmi_smi *intf,
>  	struct ipmi_recv_msg *recv_msg;
>  	struct ipmi_system_interface_addr *smi_addr;
>  
> -	recv_msg = (struct ipmi_recv_msg *) msg->user_data;
> +	recv_msg = msg->user_data;
>  	if (recv_msg == NULL) {
>  		dev_warn(intf->si_dev,
>  			 "IPMI message received with no owner. This could be because of a malformed message, or because of a hardware error.  Contact your hardware vendor for assistance.\n");
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index f199cc194844..e8ee195a33cf 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1053,7 +1053,7 @@ static void start_next_msg(struct ssif_info *ssif_info, unsigned long *flags)
>  static void sender(void                *send_info,
>  		   struct ipmi_smi_msg *msg)
>  {
> -	struct ssif_info *ssif_info = (struct ssif_info *) send_info;
> +	struct ssif_info *ssif_info = send_info;
>  	unsigned long oflags, *flags;
>  
>  	BUG_ON(ssif_info->waiting_msg);
> @@ -1090,7 +1090,7 @@ static int get_smi_info(void *send_info, struct ipmi_smi_info *data)
>   */
>  static void request_events(void *send_info)
>  {
> -	struct ssif_info *ssif_info = (struct ssif_info *) send_info;
> +	struct ssif_info *ssif_info = send_info;
>  	unsigned long oflags, *flags;
>  
>  	if (!ssif_info->has_event_buffer)
> @@ -1107,7 +1107,7 @@ static void request_events(void *send_info)
>   */
>  static void ssif_set_need_watch(void *send_info, unsigned int watch_mask)
>  {
> -	struct ssif_info *ssif_info = (struct ssif_info *) send_info;
> +	struct ssif_info *ssif_info = send_info;
>  	unsigned long oflags, *flags;
>  	long timeout = 0;
>  
> -- 
> 2.25.1
>