Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933701AbXEGMwj (ORCPT ); Mon, 7 May 2007 08:52:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933700AbXEGMwj (ORCPT ); Mon, 7 May 2007 08:52:39 -0400 Received: from khc.piap.pl ([195.187.100.11]:56528 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933691AbXEGMwi (ORCPT ); Mon, 7 May 2007 08:52:38 -0400 To: Roman Zippel Cc: Jeff Garzik , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" References: From: Krzysztof Halasa Date: Mon, 07 May 2007 13:56:41 +0200 In-Reply-To: (Roman Zippel's message of "Mon, 7 May 2007 13:22:40 +0200 (CEST)") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 962 Lines: 28 Roman Zippel writes: >> You don't have to know it's required, you can just select a driver >> for your hardware, without enabling HDLC first. > > Is this a real problem? I think the "select" is better. > Using select you should also consider removing HDLC as visible option and > use only select. Mixing depends and selects is generally a bad idea. It has to stay there for external modules. It's similar to MII - drivers select MII automatically but you can turn it on (Y or M) by hand as well. And you can have HDLC=y and driver=m (and it makes perfect sense). Actually I can't see any bad idea here. The original dependency was certainly, uhm, not the best one. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/