Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 13:08:01 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Martin Kaiser <martin@kaiser.cx>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Michael Straube <straube.linux@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: r8188eu: use ARRAY_SIZE for mlme_sta_tbl
Message-ID: <20220422100800.GG2462@kadam>
References: <20220417102221.466524-1-martin@kaiser.cx>
 <20220417102221.466524-7-martin@kaiser.cx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220417102221.466524-7-martin@kaiser.cx>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vPCJ/R0uqzrm3VvdjEOEFpTMZihWq9KCcwHgOno5S83LNzeK76VmHZhfqtlB?=
 =?us-ascii?Q?yd5UEJAehnVNqq/8JgdECL0HKcItBdns/iHfGexgpCu7oyEs0PMsvmVBYtyT?=
 =?us-ascii?Q?5DXZj6xP0wbG1VftYm8IqjQ4/d5Dm4xgH4HTrjOnklYdMLlzw2nl4Io8unU4?=
 =?us-ascii?Q?zANxAOC4iVhJewaH3MZUouMVWsA/+73sYeszfhO+uc7zPdHdp4/9kXz0iqt8?=
 =?us-ascii?Q?SY04V7x+mqwycGJC54rFt+tC7eK/yXmTs8Jx8Sig+7PHsEcF9BFwDoHr4UkS?=
 =?us-ascii?Q?L95RiegWeS9+EvjVIoC1wF5WzMXb9JZ20dOl9NQkeDzY/VMPy+3Vu6umRH+I?=
 =?us-ascii?Q?D7gZZ4RLJnnKiLL9nf7qZqeJwUqFvMir/4YFGwtsN1r7w92uHG38KVSH0MYd?=
 =?us-ascii?Q?zcXeL26XTSZeC/lfrgGQNN9u0NDTHu+ulBo3rfoPcPF20eUJ3T2HYqoQsTGG?=
 =?us-ascii?Q?XhbbDYmaBf81l5tJa3t8lpZ/HAkFDvryM7S4fdlhS0Bc6NHVUmDqArzOEL1j?=
 =?us-ascii?Q?hZu6tFZ8xN3SLB9O96meLRJBzdnUuR4Gg88KE73AocZkO03LyKkzSYpkfxm9?=
 =?us-ascii?Q?QEpykEm5sMhljSunMqi4be9SDCqZ4SaYQGhx/6WUDb7ezSU3+hO1wdCjb6cs?=
 =?us-ascii?Q?j05nSD9YaDSbo9lrU+Mi3oUVvBaBQvbJQqC1RNAuk2c6eX+ytDM5yAEJY9bM?=
 =?us-ascii?Q?E2T0XLz/1ZtxrsPknGrOAgcswqlr4v42jqgenSEbEPtJ4CX5TikJ3oRfNWXM?=
 =?us-ascii?Q?VGcQueQMTyzUeYIXHzZvF/Rdt6+ADxqW9Mc0eEzqfH6XlMSiKz20+Rh2CYe6?=
 =?us-ascii?Q?l4kcOiAQv3SY6xrAR5J55Jmwxt+EPtR3ENrGGlzMge0oEersxdSkDa0j7Ud0?=
 =?us-ascii?Q?qLsDIQmymhQa//fl7r20ZpyxPyaEcV+bc5yi/0jmh/+E9D/a2kFAbROyX1l+?=
 =?us-ascii?Q?iUTLNvDx4u/PXkyIdSmC00lHTyGr70Hgbr1VR+4BV6shkwq5hzPChD3AGBQq?=
 =?us-ascii?Q?gwDrhmz5FwngjP0ww5K/foe/SauF45AsSl5l1KCNXfLygYUGQdZKfWvAQTZm?=
 =?us-ascii?Q?E38dgF211OYPpaCZhr2byfuuiifMNapWIMoU99genYgtSUg+dgYgWsEBl3kj?=
 =?us-ascii?Q?JoGe01vd+eRa4SvWW0bdctvxQ4E7bYnA21t7p7NA576QHTsiOE23hHuzlrMG?=
 =?us-ascii?Q?XjcuemjKe3mBympn2qpezZ+5F0WNOPa8kTt+iHWTbdQ00CVghpAbS4/XzG5s?=
 =?us-ascii?Q?MMXplKxTIAYi2zfIGXVMEI0agkKKgW2NJ+qJSV3WPcdHQ+D6TlGap7EvDbiz?=
 =?us-ascii?Q?d/f943YMLB3L1QklAqlIX2soWIcEV56lz+0doUxe4VW5CLIOCnXykqoe/P5h?=
 =?us-ascii?Q?QXbEwUdi6cM2Y1N7oQQETP150Nvt+VpCYua1IiFBMg/orUQToz0REdaI13+z?=
 =?us-ascii?Q?fNKIyx7lV+ISpIhIl6C1YfofQbD01pCoT/eb0st+KUQmFYILxIXz9NF4Ra7t?=
 =?us-ascii?Q?J/y9sr9o50oLDbrBOW67ZQp1xcU8fbOq0BIjKvWt7BDBVvGdnE1dzXHLo4eb?=
 =?us-ascii?Q?T1zOT4fv4V7vZoQomznKySwUCS8gUmUwxoksdmnFv4aOMzH2FuHRgquMaOHQ?=
 =?us-ascii?Q?bN9kKvkcHM848QChLWzsWv/4fO+/+wQsRvCW6/MuDqi7dJy59TxbWuj78D5E?=
 =?us-ascii?Q?TzF5ImUrCSGTCO6OyVhIkk9cFL9X19/lZAi6EZxkUb6emTUJMQW4ZC6/y3jW?=
 =?us-ascii?Q?7adLz5UCLdAQ1SFXasXexHQ0U901puw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5a022d6-e25f-43ac-6d7a-08da2448085f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 10:08:22.4782
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JhdxO08o6JWBafWvl/1IR2ts6wfDSvfKjNX1+7QpaGO0ephNrrix6DZUIhaRtzeNlqMosxwJa8bY5Q8J5UMEdwG8bJ1SFiHnyYg83R4AeUE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4666
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-22_02:2022-04-22,2022-04-22 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204220045
X-Proofpoint-GUID: dK1k4QreOyjI2yQAH3HjitNDTgNxHqAp
X-Proofpoint-ORIG-GUID: dK1k4QreOyjI2yQAH3HjitNDTgNxHqAp
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Apr 17, 2022 at 12:22:21PM +0200, Martin Kaiser wrote:
> Use ARRAY_SIZE instead of hard-coding the number of entries in the
> mlme_sta_tbl array.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> index abb910f33c1c..973adebdd69c 100644
> --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
> @@ -404,7 +404,7 @@ void mgt_dispatcher(struct adapter *padapter, struct recv_frame *precv_frame)
>  		return;
>  
>  	index = (le16_to_cpu(hdr->frame_control) & IEEE80211_FCTL_STYPE) >> 4;
> -	if (index > 13)
> +	if (index > ARRAY_SIZE(mlme_sta_tbl))
                  ^
This is an off by one.  Should be >=.  The auto builders would have
caught this eventually.

>  		return;
>  	fct = mlme_sta_tbl[index];

regards,
dan carpenter