Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933827AbXEGNV0 (ORCPT ); Mon, 7 May 2007 09:21:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933815AbXEGNV0 (ORCPT ); Mon, 7 May 2007 09:21:26 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:45258 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933814AbXEGNVZ (ORCPT ); Mon, 7 May 2007 09:21:25 -0400 Message-ID: <463F27CE.2040008@garzik.org> Date: Mon, 07 May 2007 09:21:18 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.10 (X11/20070302) MIME-Version: 1.0 To: Roman Zippel CC: Krzysztof Halasa , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.8 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 855 Lines: 25 Roman Zippel wrote: > Hi, > > On Mon, 7 May 2007, Krzysztof Halasa wrote: > >> Actually I can't see any bad idea here. >> The original dependency was certainly, uhm, not the best one. > > select seriously screws with the dependencies, it's especially problematic > if the selected symbol has other dependencies as HDLC in this case, it > makes it only more complicated to get the dependencies correct again. > Please use it only if it solves a real problem. What he's doing is the standard way to deal with library-style code. Nothing wrong with the patch, it's continuing established methods. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/