Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp799544pxb; Fri, 22 Apr 2022 11:23:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1fpJ1wniFsq206vPyy+ghM2dxjiowFEoivARlLjYcraDwW6/2IU3eWtQ4YM5pLv3T4lqo X-Received: by 2002:a63:c008:0:b0:3a2:4b:ab0a with SMTP id h8-20020a63c008000000b003a2004bab0amr5013948pgg.588.1650651812475; Fri, 22 Apr 2022 11:23:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650651812; cv=none; d=google.com; s=arc-20160816; b=KUoST/FwTHwkpYcfdLRPryS3D29lyDjkhDiX54Ei3CnWDU8htq3g5CNlJbKRUuMmGT N7Iuw4FMoSgrjbOIs7PChMkjLdFQLrD3Va/sgQCiwxjDryHw1Vufco2xa2zwtakqQb5Q lqqAarZ1gKTajhnaFdyrbfsbN06IUGakBcpRvIxvNlnO846zjkROgu55xsXCWtvN6kFd xXX6dEllO7qApCLoRHg/I9gDsZ8vgDJzR3VFew1zz/kPHYbVW6HNUubjneGYoXD3wmwL QHPCybTNDbL6hghOVJ3YGinYJnpaBKn/ifZXSf3l4xyiLgC10J1Dk/DkpMGj36BItrDE w5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:dkim-signature:dkim-signature:date; bh=VVj4PC9oWNqvYVPXKPf4qEimB9W75/+kwVZ5tR23GpI=; b=WFr02JQJHAinm/5VlL90hUnRVu0yg42mQYqirbKsHhHEfHe6qvtZqYTm7FX4R744yw JWp8tl5xLVU4L1brfn4vDDfy9TnMKwUEjYFrgw3/iFpW19aRpGaIetrgojZng2YP5vBu o5D8iakBcng+yS8pJWx9C1p2Xs1/v5E7kKZDSxP1p4qqhRxSiWJsmNGBlZZJPJDsw/Mn LLkBFXL47gRxudd8s6sZrG7vJXPr14YHQdneMlWBmJh1QJyycB9d6bHF75Ahe3IfXHbE +SNSYv71T4x/58zeZQ5W11yffYN2O4N1YXx0/rv5CKGXnFr4d9y573ZAtBV7VVTqZ/I4 mClQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=XuI+FMLz; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h62-20020a638341000000b003816043ee11si8833958pge.6.2022.04.22.11.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:23:32 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=XuI+FMLz; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1A5DDDC58C; Fri, 22 Apr 2022 10:53:31 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343534AbiDTP7m (ORCPT + 99 others); Wed, 20 Apr 2022 11:59:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242908AbiDTP7l (ORCPT ); Wed, 20 Apr 2022 11:59:41 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EE32DD63 for ; Wed, 20 Apr 2022 08:56:55 -0700 (PDT) Date: Wed, 20 Apr 2022 17:56:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1650470213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVj4PC9oWNqvYVPXKPf4qEimB9W75/+kwVZ5tR23GpI=; b=XuI+FMLzOWNK0frrgUoXV8NElncf/dmQtHo1wQaRoKrXtriVicAAu+eLQUn1NfTcc+5Uoc Aza3nXF97Gr+bhoQQoA/IrJY0ijOjUeVkF9AzThgV10uVH7zw3yetKIKELAJkt8KBZcbLa bja5awR4dB67a6gVmtqf85vRn8776HmZG4K4X0o4fg1SCZ708Q4Bk5ovBH5kZgR9vSgEum GlxBeKxRguORhDYuLZ14CdSNjbL3UPS/uzGu2o04V+tlIRi3MJ1EpP0YHaGu1EWz3fpDuI grxhHufQFSVM6l1JVJSy4ql7q4W02dqsi1kMtdS9Vnt1eAtMe43Gj4J15YUrAA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1650470213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVj4PC9oWNqvYVPXKPf4qEimB9W75/+kwVZ5tR23GpI=; b=DM27W01wqlcTieEjBDOGN84ro76MphENbP1EauMN0mtTmhqZ11Gx0bhVQyGZkx0Q/eZjBS P2fqeYCSvVI6BjAQ== From: Sebastian Andrzej Siewior To: Thomas Gleixner Cc: LKML , Christoph Hellwig , Peter Zijlstra Subject: Re: [patch V5 3/3] smp: Make softirq handling RT safe in flush_smp_call_function_queue() Message-ID: References: <20220413132836.099363044@linutronix.de> <20220413133024.356509586@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220413133024.356509586@linutronix.de> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-04-13 15:31:05 [+0200], Thomas Gleixner wrote: =E2=80=A6 > +#ifdef CONFIG_PREEMPT_RT > +extern void do_softirq_post_smp_call_flush(unsigned int was_pending); > +#else > +static inline void do_softirq_post_smp_call_flush(unsigned int unused) > +{ > + do_softirq(); > +} > +#endif > + =E2=80=A6 > +void softirq_post_smp_call_flush(unsigned int was_pending) > +{ > + if (WARN_ON_ONCE(was_pending !=3D local_softirq_pending())) > + invoke_softirq(); > +} > + > #else /* CONFIG_PREEMPT_RT */ fold, please. Signed-off-by: Sebastian Andrzej Siewior --- kernel/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/softirq.c b/kernel/softirq.c index 1682586a69139..5b36ebe5e20de 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c @@ -301,7 +301,7 @@ static inline void invoke_softirq(void) * get raised which haven't been raised before the flush, warn so it can be * investigated. */ -void softirq_post_smp_call_flush(unsigned int was_pending) +void do_softirq_post_smp_call_flush(unsigned int was_pending) { if (WARN_ON_ONCE(was_pending !=3D local_softirq_pending())) invoke_softirq(); Sebastian