Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp799939pxb; Fri, 22 Apr 2022 11:24:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx018sllZt+YG81YSWmBH7hZi9cxYvutynI5hJQUMmeIjzPGFS9h85yObdXf1huINHl+zrp X-Received: by 2002:a17:902:a707:b0:15b:6ea2:8ea2 with SMTP id w7-20020a170902a70700b0015b6ea28ea2mr5689391plq.134.1650651844268; Fri, 22 Apr 2022 11:24:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650651844; cv=none; d=google.com; s=arc-20160816; b=S0ab59ydIr7+ZMqdpw3r3NSPIcy0EOkTtorYRoZlijahvmXyLpeTAANY0VkKHZvkns QyvA1rQL+Q/K9B5OxBMQCwCEEfNKxCNE/J/buD9y758ZKeNZjwthX5T0dfBcv99YNcF1 q95hoSfk8OgnWZ7/1JRGxVlhizIyM0j0wL7//MjlBdd8uZa1CwLK5iqRAbRpUem5e5T/ B75L9XYn9ggONig0wD0KuDAF0QZcLhTNEFMcIxNK+1fYZ2fvu6ytoa99nmmnpS5pEiXb HbB3WGmPjRGe34MgIen7s9kLqTxKP/GdTJuiaqv2fdfFQpcoBVVzUXU6TgueTRZcO09a ZhZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=mhiX9pOS55YaO3CdrDwpUy6BkzPbq10Xj73NWvQBwAg=; b=KYjqWJ3jtXnEf0JqZ0wFlYYtRso255u68ltR1c5IG9FkQDJiuh6dc8c7k+EphAj0DF cGMcUX2Q8vwDdtuP2NFC1O8X2HVCKn33yScB0oE3rcph74zD/ugpXRHE84JzBfG7fNhz Uv37R6KzIeJVNRRAlzZcIe0jnPysCIpSHqkRaBLlxOM6yAetPhTMrX8/gM2K++ga7irb 6qVSHqa8+n/1hGoOeVnoPq9j2O2OessNz1akVY0+a17X6sGzA8HbNUPh6DJyjFlGi2S0 GQjbpSnScfO4BsnhhuUAI7XkG+kP3VijSeOk72egm7+QTrGnT4wDPbaXff9fOuizJIlu WO7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vRUi3XTt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 14-20020a63020e000000b003816043f141si8993693pgc.822.2022.04.22.11.24.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:24:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vRUi3XTt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2DB051467D2; Fri, 22 Apr 2022 10:53:54 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1448543AbiDVOTQ (ORCPT + 99 others); Fri, 22 Apr 2022 10:19:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1448529AbiDVOTO (ORCPT ); Fri, 22 Apr 2022 10:19:14 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41B305AECC for ; Fri, 22 Apr 2022 07:16:21 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id c23so11177109plo.0 for ; Fri, 22 Apr 2022 07:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=mhiX9pOS55YaO3CdrDwpUy6BkzPbq10Xj73NWvQBwAg=; b=vRUi3XTt6AzV9QlheY6fezduSTcEh/sZN3k+dAddNZiw8rhhyhbGXtJLNYs3J/UwD5 bRx0NNWnHM1TYIelLSIgCtSpmnbMKDgukzfetN9iXKdtLRwPXB54SYzt6H400lsd3P4D ++PGiqJSRNedibPs1CaxKSPMQyTwkUYyruCII4+3lOh3uWSvP8+idLkPjw5BBA8QJsEi kvO8DlCiTkUMJj9c+3Kb4kPubeS7hxUdkzPshkGtiJXpeZOSSMzbk6sHBs+4HmVJPMRp e9Uz5m7trgk2XIsiSCfl29aZ0LqcmQ7ZWTP8PJh4RgMon1aGFHXpRKjuAUHuYVAvcCcH noKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=mhiX9pOS55YaO3CdrDwpUy6BkzPbq10Xj73NWvQBwAg=; b=m5hIAFvszlhsmHPkSBOlgxx9Gco5LQpB3ybbWFUYBYiHQRu76fUHMaGojIBM8BQ9jg MLnUb5UIpSujhjJfG5DVkmouFSZmM8ikR5dv27UM0BFK4lm1u8BizE181wAkL1bXtxqj 6/ZRkwX2xkJKVNpo99Ilj/1Nl45Arh0gU/ahrxpXcPJENbMhkfi3d/sxa82Oi2vbJbA8 tC16ZFnH/IuvsBkhGPqGUo6yFvm2+Fe0n62r55CUitxsBbLk8NlsB+9k6fZB6duHftTR JbzXnH3C5GtgFVL19IPnpQPOJGeA1Gw3EB7oXdJ4URxjA6qF5SvqZ8WV60hCuLUu+3+j 4VBg== X-Gm-Message-State: AOAM530c9C2qlrs1XC2E1NETufZ39ermjfNncGXoUW8aZFgWK1fJVQyu 8YdkiEvgZ7WAKJE3ss597xWEwm22A5QlQJslIT5UfQ== X-Received: by 2002:a17:903:2352:b0:159:3fa:261 with SMTP id c18-20020a170903235200b0015903fa0261mr4632628plh.21.1650636980753; Fri, 22 Apr 2022 07:16:20 -0700 (PDT) MIME-Version: 1.0 References: <20220419010852.452169-1-victor.liu@nxp.com> <20220419010852.452169-2-victor.liu@nxp.com> In-Reply-To: <20220419010852.452169-2-victor.liu@nxp.com> From: Robert Foss Date: Fri, 22 Apr 2022 16:16:09 +0200 Message-ID: Subject: Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() To: Liu Ying Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org, andrzej.hajda@intel.com, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, agx@sigxcpu.org, robert.chiras@nxp.com, martin.kepplinger@puri.sm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 19 Apr 2022 at 03:07, Liu Ying wrote: > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > a MIPI DSI display or a LVDS display. So, this patch calls > phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY > explicitly. > > Cc: Guido G=C3=BCnther > Cc: Robert Chiras > Cc: Martin Kepplinger > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Laurent Pinchart > Cc: Jonas Karlman > Cc: Jernej Skrabec > Cc: David Airlie > Cc: Daniel Vetter > Cc: NXP Linux Team > Signed-off-by: Liu Ying > --- > v7->v8: > * Resend with Andrzej's and Jernej's mail addressed updated. > > v6->v7: > * No change. > > v5->v6: > * Rebase the series upon v5.17-rc1. > * Set PHY mode in ->mode_set() instead of ->pre_enable() in the nwl-dsi > bridge driver due to the rebase. > * Drop Guido's R-b tag due to the rebase. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * No change. > > v1->v2: > * Add Guido's R-b tag. > > drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nw= l-dsi.c > index d5945501a5ee..85bab7372af1 100644 > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > @@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi *dsi) > return ret; > } > > + ret =3D phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); > + if (ret < 0) { > + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", re= t); > + goto uninit_phy; > + } > + > ret =3D phy_configure(dsi->phy, phy_cfg); > if (ret < 0) { > DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", r= et); > -- > 2.25.1 > Acked-by: Robert Foss