Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Dylan Yudaken <dylany@fb.com>
To:     <io-uring@vger.kernel.org>
CC:     <axboe@kernel.dk>, <asml.silence@gmail.com>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>,
        Dylan Yudaken <dylany@fb.com>
Subject: [PATCH 3/6] io_uring: rework io_uring_enter to simplify return value
Date:   Thu, 21 Apr 2022 02:13:42 -0700
Message-ID: <20220421091345.2115755-4-dylany@fb.com>
In-Reply-To: <20220421091345.2115755-1-dylany@fb.com>
References: <20220421091345.2115755-1-dylany@fb.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain
Precedence: bulk

io_uring_enter returns the count submitted preferrably over an error
code. In some code paths this check is not required, so reorganise the
code so that the check is only done as needed.
This is also a prep for returning error codes only in waiting scenarios.

Signed-off-by: Dylan Yudaken <dylany@fb.com>
---
 fs/io_uring.c | 35 +++++++++++++++++++++--------------
 1 file changed, 21 insertions(+), 14 deletions(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index d654faffa486..1837b3afa47f 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -10843,7 +10843,6 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, fd,=
 u32, to_submit,
 		size_t, argsz)
 {
 	struct io_ring_ctx *ctx;
-	int submitted =3D 0;
 	struct fd f;
 	long ret;
=20
@@ -10906,15 +10905,15 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, f=
d, u32, to_submit,
 			if (ret)
 				goto out;
 		}
-		submitted =3D to_submit;
+		ret =3D to_submit;
 	} else if (to_submit) {
 		ret =3D io_uring_add_tctx_node(ctx);
 		if (unlikely(ret))
 			goto out;
=20
 		mutex_lock(&ctx->uring_lock);
-		submitted =3D io_submit_sqes(ctx, to_submit);
-		if (submitted !=3D to_submit) {
+		ret =3D io_submit_sqes(ctx, to_submit);
+		if (ret !=3D to_submit) {
 			mutex_unlock(&ctx->uring_lock);
 			goto out;
 		}
@@ -10923,6 +10922,7 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, fd,=
 u32, to_submit,
 		mutex_unlock(&ctx->uring_lock);
 	}
 	if (flags & IORING_ENTER_GETEVENTS) {
+		int ret2;
 		if (ctx->syscall_iopoll) {
 			/*
 			 * We disallow the app entering submit/complete with
@@ -10932,22 +10932,29 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, f=
d, u32, to_submit,
 			 */
 			mutex_lock(&ctx->uring_lock);
 iopoll_locked:
-			ret =3D io_validate_ext_arg(flags, argp, argsz);
-			if (likely(!ret)) {
-				min_complete =3D min(min_complete, ctx->cq_entries);
-				ret =3D io_iopoll_check(ctx, min_complete);
+			ret2 =3D io_validate_ext_arg(flags, argp, argsz);
+			if (likely(!ret2)) {
+				min_complete =3D min(min_complete,
+						   ctx->cq_entries);
+				ret2 =3D io_iopoll_check(ctx, min_complete);
 			}
 			mutex_unlock(&ctx->uring_lock);
 		} else {
 			const sigset_t __user *sig;
 			struct __kernel_timespec __user *ts;
=20
-			ret =3D io_get_ext_arg(flags, argp, &argsz, &ts, &sig);
-			if (unlikely(ret))
-				goto out;
-			min_complete =3D min(min_complete, ctx->cq_entries);
-			ret =3D io_cqring_wait(ctx, min_complete, sig, argsz, ts);
+			ret2 =3D io_get_ext_arg(flags, argp, &argsz, &ts, &sig);
+			if (likely(!ret2)) {
+				min_complete =3D min(min_complete,
+						   ctx->cq_entries);
+				ret2 =3D io_cqring_wait(ctx, min_complete, sig,
+						      argsz, ts);
+			}
 		}
+
+		if (!ret)
+			ret =3D ret2;
+
 	}
=20
 out:
@@ -10955,7 +10962,7 @@ SYSCALL_DEFINE6(io_uring_enter, unsigned int, fd,=
 u32, to_submit,
 out_fput:
 	if (!(flags & IORING_ENTER_REGISTERED_RING))
 		fdput(f);
-	return submitted ? submitted : ret;
+	return ret;
 }
=20
 #ifdef CONFIG_PROC_FS
--=20
2.30.2