Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933949AbXEGNqQ (ORCPT ); Mon, 7 May 2007 09:46:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933933AbXEGNqN (ORCPT ); Mon, 7 May 2007 09:46:13 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:1137 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933928AbXEGNqM (ORCPT ); Mon, 7 May 2007 09:46:12 -0400 Date: Mon, 7 May 2007 15:46:08 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Jeff Garzik cc: Krzysztof Halasa , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" In-Reply-To: <463F27CE.2040008@garzik.org> Message-ID: References: <463F27CE.2040008@garzik.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1001 Lines: 24 Hi, On Mon, 7 May 2007, Jeff Garzik wrote: > > select seriously screws with the dependencies, it's especially problematic > > if the selected symbol has other dependencies as HDLC in this case, it makes > > it only more complicated to get the dependencies correct again. > > Please use it only if it solves a real problem. > > What he's doing is the standard way to deal with library-style code. Nothing > wrong with the patch, it's continuing established methods. select was never meant as autoconfiguration tool. It can't be said often enough: select seriously screws with the dependencies, _please_ don't use it as a simple depends replacement. HDLC doesn't really look like simple library code, what's up with all the HDLC_* options? bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/