Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp803794pxb; Fri, 22 Apr 2022 11:29:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFPvUNMzuvoNJ8+N+t1gJ978oUuJYEzGoLshrIo5rdWpLY5s4T0TtWivWTq7H3bZcPWdRR X-Received: by 2002:a17:902:b213:b0:156:5a00:325f with SMTP id t19-20020a170902b21300b001565a00325fmr5805892plr.127.1650652141109; Fri, 22 Apr 2022 11:29:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650652141; cv=none; d=google.com; s=arc-20160816; b=So6bE9Rab0aHSQOUvwA3Ro3a7k6qrCu/Pf5ocPDnOaIH1CGztBYtXrcxw2za+0HfgD E/weYlx/dz5umEQs4Mdhm18dFH1aa5erWcTKiqHcPEzzkg7W4G+JlACCuWQr9gDFBo4h +HQ8nZ+G2QPwZZWtAgBe1obFkd6mYzmWAuk4tllOkr6seXgTgYJCFlcHaIbSbnV/QhUi YBwUv6nt/P0X/hKjX3YKkMrHxybs7plLzh/+zlZUWH/Kr1fhXVeK/sZ88BgJ3sFY0QZ2 +cA6R4QAg6OOeXPegstCFL85GMDXpH+Kul6Vau3YWXCu6oBehfjqB12RhSloDMVGEL/E 4pDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:mime-version:user-agent:message-id :in-reply-to:date:references:cc:to:from; bh=fC5qS6cCsqmMgjMqTRg6lNuMQIHL2cKDFw0etsJu9qk=; b=GwyECF/EcBMDz3Uy09MEilNivlQbcke/AvxDTRvim4ngwpZeSahI4MUjlUT1PG42A5 3jT2QVXnHVr/6BSzk2su+0GRLjSIUvkAqudqdiPwRv+ZAr5VLINgcYP9HMJM1P+Yeyp8 uinKyWU3nD+nfc3jCNgCNEEIH984OMD9sRaFwkg2Q1Sj/yiP5I9xwXZGmsSGu9wRMCU2 OGsBJLH+7GelogJsFMAyrj2pTOIBGJ16Xta6oJxEQJHIBu7fke/ZFUNKi9P/MAZAlRrO 242S2Yufd30zp6Kk5N1rc1TANXMOuxUgTlMM40qDhPCrBipkVasy7bD+Hcnaawu+6Y0a HzaA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j3-20020a170903028300b00158f817a27bsi929421plr.148.2022.04.22.11.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:29:01 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BC27414B671; Fri, 22 Apr 2022 10:58:34 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389840AbiDUPEF (ORCPT + 99 others); Thu, 21 Apr 2022 11:04:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1389841AbiDUPEB (ORCPT ); Thu, 21 Apr 2022 11:04:01 -0400 Received: from out03.mta.xmission.com (out03.mta.xmission.com [166.70.13.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8981C443ED; Thu, 21 Apr 2022 08:01:11 -0700 (PDT) Received: from in01.mta.xmission.com ([166.70.13.51]:43958) by out03.mta.xmission.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nhYIw-00FLoJ-8n; Thu, 21 Apr 2022 09:01:10 -0600 Received: from ip68-227-174-4.om.om.cox.net ([68.227.174.4]:35194 helo=email.froward.int.ebiederm.org.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nhYIv-009aEA-3r; Thu, 21 Apr 2022 09:01:09 -0600 From: "Eric W. Biederman" To: Oleg Nesterov Cc: Peter Zijlstra , rjw@rjwysocki.net, mingo@kernel.org, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, mgorman@suse.de, bigeasy@linutronix.de, Will Deacon , linux-kernel@vger.kernel.org, tj@kernel.org, linux-pm@vger.kernel.org References: <20220414115410.GA32752@redhat.com> <20220414183433.GC32752@redhat.com> <20220415101644.GA10421@redhat.com> <20220415105755.GA15217@redhat.com> <20220418170104.GA16199@redhat.com> <20220420131731.GF2731@worktop.programming.kicks-ass.net> <20220420180323.GA14947@redhat.com> <875yn3zdag.fsf_-_@email.froward.int.ebiederm.org> <20220421094640.GA18344@redhat.com> Date: Thu, 21 Apr 2022 10:01:02 -0500 In-Reply-To: <20220421094640.GA18344@redhat.com> (Oleg Nesterov's message of "Thu, 21 Apr 2022 11:46:41 +0200") Message-ID: <878rryxyz5.fsf@email.froward.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1nhYIv-009aEA-3r;;;mid=<878rryxyz5.fsf@email.froward.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.174.4;;;frm=ebiederm@xmission.com;;;spf=softfail X-XM-AID: U2FsdGVkX1+NV/MeA4RuUk65001EaQXJ7hjH0TPEZjc= X-SA-Exim-Connect-IP: 68.227.174.4 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ***;Oleg Nesterov X-Spam-Relay-Country: X-Spam-Timing: total 498 ms - load_scoreonly_sql: 0.08 (0.0%), signal_user_changed: 11 (2.3%), b_tie_ro: 10 (2.0%), parse: 1.33 (0.3%), extract_message_metadata: 4.0 (0.8%), get_uri_detail_list: 0.93 (0.2%), tests_pri_-1000: 6 (1.2%), tests_pri_-950: 1.85 (0.4%), tests_pri_-900: 1.47 (0.3%), tests_pri_-90: 226 (45.5%), check_bayes: 224 (45.0%), b_tokenize: 8 (1.7%), b_tok_get_all: 4.7 (0.9%), b_comp_prob: 4.7 (0.9%), b_tok_touch_all: 203 (40.7%), b_finish: 1.07 (0.2%), tests_pri_0: 220 (44.3%), check_dkim_signature: 0.93 (0.2%), check_dkim_adsp: 4.8 (1.0%), poll_dns_idle: 1.88 (0.4%), tests_pri_10: 1.99 (0.4%), tests_pri_500: 10 (2.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [RFC][PATCH] ptrace: Don't change __state X-SA-Exim-Version: 4.2.1 (built Sat, 08 Feb 2020 21:53:50 +0000) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oleg Nesterov writes: > On 04/20, Eric W. Biederman wrote: >> @@ -892,7 +891,6 @@ static int ptrace_resume(struct task_struct *child, long request, >> * status and clears the code too; this can't race with the tracee, it >> * takes siglock after resume. >> */ >> - need_siglock = data && !thread_group_empty(current); >> if (need_siglock) >> spin_lock_irq(&child->sighand->siglock); > > Hmm? A half backed out change (I thought ptrace_resume would need to clear JOBCTL_DELAY_WAKEKILL) in ptrace_resume. I somehow failed to restore the need_siglock line. Eric