Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbXEGOCX (ORCPT ); Mon, 7 May 2007 10:02:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754322AbXEGOCV (ORCPT ); Mon, 7 May 2007 10:02:21 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:2649 "EHLO spitz.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754298AbXEGOCV (ORCPT ); Mon, 7 May 2007 10:02:21 -0400 Date: Mon, 7 May 2007 14:01:48 +0000 From: Pavel Machek To: Anton Vorontsov Cc: Greg KH , linux-kernel@vger.kernel.org, kernel-discuss@handhelds.org, David Woodhouse Subject: Re: [PATCH 5/8] APM emulation driver for class batteries Message-ID: <20070507140148.GC3868@ucw.cz> References: <20070503213237.GE20067@zarina> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070503213237.GE20067@zarina> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 874 Lines: 27 Hi! > Signed-off-by: Anton Vorontsov > --- > drivers/power/Kconfig | 7 ++ > drivers/power/Makefile | 1 + > drivers/power/apm_power.c | 249 +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 257 insertions(+), 0 deletions(-) > create mode 100644 drivers/power/apm_power.c > > +#ifdef current > +#undef current /* it expands to get_current() */ > +#endif Uff, now that's a dirty hack. Can you rename your variables? current -> I? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/