Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp813726pxb; Fri, 22 Apr 2022 11:43:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuOQJsMgW8VetoaZh4wWbPqPYkKm/a4ip4AEvubvBJlV9HYk/L4DnBLT+TE/Q5+4r4B75L X-Received: by 2002:a17:90a:a393:b0:1d0:e448:811d with SMTP id x19-20020a17090aa39300b001d0e448811dmr17693380pjp.97.1650653024284; Fri, 22 Apr 2022 11:43:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650653024; cv=none; d=google.com; s=arc-20160816; b=FYd2cch74jf5ER3FbZxpiIqeVjUwXH6ZW5XFwSth3oHuTp2rnbcTSpzCZns2Fqd9He q7udy8a3WGbTq9juO4DX+6ZyHV9M3RnnpPSVb41LMZA4f+oDrfNdQS/FUaG7lFP3vN4l Gbl0cND9KSarSJ9F2HqYUumtu4f8Ro5DiH+WuPyUYizEHfE4EDmUyqGDvD+nAc3UrRXs KAwowUaBMq9bvlOu+5jXTA0B1Z6sqrBwJAN1nepbWu5FwdKSs53obrFEuPM1csfNY4m/ /0gf+cpZgvN1cv3NKp9wmesRcbC/8RLpL5uw+9Xc5ugsuDzJXRBDFl/z4h5hWKIFZdzM wzcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=USmguGtRv7OyG/vAnutBvtLlevB2Qy+jsc9UPAQ49fo=; b=avA2ARIPCDOTFsYlBofDXngcTXTMDVJEocaUnOezHhGgX6zNNGCWkJeewu20dhMCFU A8rBx+e1gw+LABkKy9Opqn8AvFUSk0QGdIFp8UGwghmoEGbxfX2JZQakouRm8JxSn9qi OU5XQ0rjSOpfDYlAHrHLmhpCy7AZ2ILGJVCpHpKu0t4oBV1EJybOcbDJrKM05P38OLFM rQVT3vIAINIM5WjgGCPl1DmyVjJSxrsbKnzVfHatE4EepO9sFvEkwnn3/TkjnxGh9Tmq o7pNYWmR0gE/ok3axgS7NASWFhT3miCAvCOMPOsfOqT4j16X35SP1wLFoD/hiQNOsyGq 2AjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="l/0DHe7z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id r8-20020a1709028bc800b00158897b40e5si8231787plo.48.2022.04.22.11.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:43:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="l/0DHe7z"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C1B1F12ACF3; Fri, 22 Apr 2022 11:12:06 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445419AbiDVIEE (ORCPT + 99 others); Fri, 22 Apr 2022 04:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1445394AbiDVIEB (ORCPT ); Fri, 22 Apr 2022 04:04:01 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B73DF527CC; Fri, 22 Apr 2022 01:01:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=USmguGtRv7OyG/vAnutBvtLlevB2Qy+jsc9UPAQ49fo=; b=l/0DHe7zGO6IzmY4XrVlBXV+ZP UIRAGL/FOGkgN8tHZPXIbHwhEaaWdqf6dCjWt1qzpkHq3dfoMaRdw6w1O5bdaeV6LDEtM13EVISPx p8cBXMZYzaJT8zdsF81GhzjsZI7O8g951uKy0hdzBUdtbG3wqqIweJpi8Z1Xm2ZjB2EMhkwtUbzHv 8N5m+ICLj5c0XmmcOjjzEnFKADejHe1LagakFnLt54IS3s6u4wMeB9EM3KB7HcAuZFhw3Od/i+Gs2 rG4tWNBYVMA7Lk1KQzntKBtsGtlobTTp0hyIv6NZdSxc1wcYe4hBM2SNblrZ3uoFzSk2gpkFHQAR/ ZaYUDehA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58366) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nhoDg-0004KA-BE; Fri, 22 Apr 2022 09:00:48 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nhoDZ-0003VE-F0; Fri, 22 Apr 2022 09:00:41 +0100 Date: Fri, 22 Apr 2022 09:00:41 +0100 From: "Russell King (Oracle)" To: Ong Boon Leong Cc: Alexandre Torgue , Jose Abreu , Andrew Lunn , Heiner Kallweit , Paolo Abeni , "David S . Miller" , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , Giuseppe Cavallaro , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/4] net: pcs: xpcs: add CL37 1000BASE-X AN support Message-ID: References: <20220422073505.810084-1-boon.leong.ong@intel.com> <20220422073505.810084-2-boon.leong.ong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220422073505.810084-2-boon.leong.ong@intel.com> Sender: Russell King (Oracle) X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, Apr 22, 2022 at 03:35:02PM +0800, Ong Boon Leong wrote: > @@ -774,6 +788,58 @@ static int xpcs_config_aneg_c37_sgmii(struct dw_xpcs *xpcs, unsigned int mode) > return ret; > } > > +static int xpcs_config_aneg_c37_1000basex(struct dw_xpcs *xpcs, unsigned int mode, > + const unsigned long *advertising) > +{ > + int ret, mdio_ctrl; > + > + /* For AN for 1000BASE-X mode, the settings are :- > + * 1) VR_MII_MMD_CTRL Bit(12) [AN_ENABLE] = 0b (Disable C37 AN in case > + * it is already enabled) > + * 2) VR_MII_AN_CTRL Bit(2:1)[PCS_MODE] = 00b (1000BASE-X C37) > + * 3) SR_MII_AN_ADV Bit(6)[FD] = 1b (Full Duplex) > + * Note: Half Duplex is rarely used, so don't advertise. > + * 4) VR_MII_MMD_CTRL Bit(12) [AN_ENABLE] = 1b (Enable C37 AN) So if this function gets called to update the advertisement - even if there is no actual change - we go through a AN-disable..AN-enable dance and cause the link to re-negotiate. That doesn't sound like nice behaviour. > + */ > + mdio_ctrl = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL); > + if (mdio_ctrl < 0) > + return mdio_ctrl; > + > + if (mdio_ctrl & AN_CL37_EN) { > + ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL, > + mdio_ctrl & ~AN_CL37_EN); > + if (ret < 0) > + return ret; > + } > + > + ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_AN_CTRL); > + if (ret < 0) > + return ret; > + > + ret &= ~DW_VR_MII_PCS_MODE_MASK; > + ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_AN_CTRL, ret); > + if (ret < 0) > + return ret; > + > + ret = xpcs_read(xpcs, MDIO_MMD_VEND2, MII_ADVERTISE); > + ret |= ADVERTISE_1000XFULL; > + ret = xpcs_write(xpcs, MDIO_MMD_VEND2, MII_ADVERTISE, ret); What if other bits are already set in the MII_ADVERTISE register? Maybe consider using phylink_mii_c22_pcs_encode_advertisement()? The pcs_config() method is also supposed to return either a negative error, 0 for no advertisement change, or positive for an advertisement change, in which case phylink will trigger a call to pcs_an_restart(). > +static int xpcs_get_state_c37_1000basex(struct dw_xpcs *xpcs, > + struct phylink_link_state *state) > +{ > + int lpa, adv; > + int ret; > + > + ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL); > + if (ret < 0) > + return ret; > + > + if (ret & AN_CL37_EN) { > + /* Reset link_state */ > + state->link = false; > + state->speed = SPEED_UNKNOWN; > + state->duplex = DUPLEX_UNKNOWN; > + state->pause = 0; Phylink guarantees that speed, duplex and pause are set to something sensible - please remove these. The only one you probably need here is state->link. > + > + lpa = xpcs_read(xpcs, MDIO_MMD_VEND2, MII_LPA); > + if (lpa < 0 || lpa & LPA_RFAULT) > + return false; This function does not return a boolean. Returning "false" is the same as returning 0, which means "no error" but an error has occurred. > + > + adv = xpcs_read(xpcs, MDIO_MMD_VEND2, MII_ADVERTISE); > + if (adv < 0) > + return false; Ditto. > + > + if (lpa & ADVERTISE_1000XFULL && > + adv & ADVERTISE_1000XFULL) { > + state->speed = SPEED_1000; > + state->duplex = DUPLEX_FULL; > + state->link = true; > + } > + > + /* Clear CL37 AN complete status */ > + ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_AN_INTR_STS, 0); > + } else { > + state->link = true; > + state->speed = SPEED_1000; > + state->duplex = DUPLEX_FULL; > + state->pause = 0; If we're in AN-disabled mode, phylink will set state->speed and state->duplex according to the user's parameters, so there should be no need to do it here. > @@ -994,9 +1143,21 @@ void xpcs_link_up(struct phylink_pcs *pcs, unsigned int mode, > return xpcs_config_usxgmii(xpcs, speed); > if (interface == PHY_INTERFACE_MODE_SGMII) > return xpcs_link_up_sgmii(xpcs, mode, speed, duplex); > + if (interface == PHY_INTERFACE_MODE_1000BASEX) > + return xpcs_link_up_1000basex(xpcs, speed, duplex); > } > EXPORT_SYMBOL_GPL(xpcs_link_up); > > +static void xpcs_an_restart(struct phylink_pcs *pcs) > +{ > + struct dw_xpcs *xpcs = phylink_pcs_to_xpcs(pcs); > + int ret; > + > + ret = xpcs_read(xpcs, MDIO_MMD_VEND2, MDIO_CTRL1); > + ret |= BMCR_ANRESTART; > + ret = xpcs_write(xpcs, MDIO_MMD_VEND2, MDIO_CTRL1, ret); If xpcs_read() returns an error, we try to write the error back to the control register? Is that a good idea/ Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!