Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <d4d36fb2-a26a-9fbd-acc6-fe97ab93fa66@oracle.com>
Date:   Thu, 21 Apr 2022 16:56:40 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH 2/4] xen/scsiback: use new command result macros
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>
References: <20220420092503.11123-1-jgross@suse.com>
 <20220420092503.11123-3-jgross@suse.com>
 <e4bce8f1-c6f5-cb99-8a1e-97b09ea1f840@oracle.com>
 <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <bf19c5f8-badd-5afb-fcaa-a16483783a27@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDkxRmIySDZEaXZGcXB2dkNrSC9JeUJXSXRHNG9Ub0p5WENUc3V1dlUzRTlU?=
 =?utf-8?B?TnRsV2ZwTWNZblhRUVFiTERoUmNoZDV0ZHpiMmVyY3VnUTVrSDhPdDN1T1lo?=
 =?utf-8?B?ckVlRGliV05WQ3RoQXNtTjkrYTdvbGNYTUFJSnJIZjkzeld5UFJkcmhYc3pj?=
 =?utf-8?B?SjY1L1EzeXFLVUg1cnZKWGdjWVA4VEVtdk5YZmlxMThsR3NaZVJxT1NsWFpt?=
 =?utf-8?B?YjRWbndLRmsyY1FwOThuSkxEZVlCTmo1R0hBSmd3clk5STBEbFpRYzZCTFJC?=
 =?utf-8?B?cDhqRU1SUjhvdklJNlpPcUlURTErVHQ0dTd6UzhXSEt5akVJOUlvWFlvQUZS?=
 =?utf-8?B?SmpWbjJndjNFdXlCRG1DRnV6V2FUUi90OVhNOU50YWhkM3RUVFIyRExnSy9P?=
 =?utf-8?B?RXhMSExlU28yRnJkZzVVSVcvYTA3Y1VxOVdOWEF3RDJCdkI1U1NxR0tHeXJQ?=
 =?utf-8?B?cEdveWpEN3JMSVM5ZWsxQUk4akdjQW1rTkdSdVhVL3RDZ1BFNU8rVzRRN3hH?=
 =?utf-8?B?UU0zdk11eW14WVJVY05nV0FCaGk0ckVkb1RlcEVvTklHZ0c0VjFXb0g4WXVT?=
 =?utf-8?B?aVFsMjFWMW1zSndNV0NEcldCVUNhSW8wTjFIaXYyeUlGekFrbzEvdy96Z2dJ?=
 =?utf-8?B?UVlRZDhTZmlBaXJtRmE4RkRQQmJYa1lVZ25mK2hIYkNqYWV0TTlLZ0JiaVN2?=
 =?utf-8?B?ODNXcHV4bTV0Y05oNW8yc0RNc2NRcStuVFRvUlBRS2NIWlZCZTdEWEc1MDRR?=
 =?utf-8?B?cnV3dHJ6OTRpRkhhOHB3OXRNUXRTMm0rUWRERmpvWVNHaTdPOHZSeldrazM4?=
 =?utf-8?B?YXYzMmFZQmgxR3BtRGlvc215NE9vS0lxNDJna0JuNXVLZFQvNll4M09OZVR3?=
 =?utf-8?B?eFBBak1QbG96cDZOcTh0M2h1bnZEWUNSeDFEd2RqMHBOZ1dPd0JMc0UwMktm?=
 =?utf-8?B?Z3U1MnNWS25wZ3BGQTZOQ1lvMkNjRjFUalZsRXRkUDhnbW8yS1pURUI4Y2RO?=
 =?utf-8?B?WGlDUUMxTjlwdUJKWWVxRkQ3Y3dFbzB5RlZZUFphZ05HYnQvdTZ6em0ycVZs?=
 =?utf-8?B?NDZId1BLYWFVdThkWXZzQU5DSS90VzRPemd5azhQbkVQR3lEVExUN0VDQ1Fy?=
 =?utf-8?B?bVFVT0U4NHJtNmMveG5nUndkQnJEenczTVZsVVJTR1RyaXc5SGlySnJRc1dR?=
 =?utf-8?B?b09sRUhWRXdXTWZ1TTR2MmQxZ2RDRmNJVXFpWVViUU11RXRKVmxHMVA3UnB2?=
 =?utf-8?B?RGNFamNHMjNBSkdvZEFETmVaUEQ5NkRPdkJDbFhRS3NwLzAxUmNXM3M0aUQz?=
 =?utf-8?B?dVlMQlJ0Y2JmUU1IbDREYzdhMWNITFJUWmJmSXF5SUFHTjFiNUFZNUxvUWQ3?=
 =?utf-8?B?QzFsRHRSUkNXWFFKeWx3ZVk2QWFoM2dUaWhSWTM2N0NRTEYzWHZGeG1kenRV?=
 =?utf-8?B?bDJqSG5uSGI3RUI1ZVc5YTRUWngzVjZoZWlkL1hGMEdLR3EvbytGdEJlZ2FG?=
 =?utf-8?B?RnFNUldPb2pKUFBjQjMzaDRSb0pPM056QW9UZkM2ZXo0NE5RV2swd25CWHI1?=
 =?utf-8?B?cWxLYkVPd081Y1ZPMk9nOTJnMnJhKzVpUVpZK0oxQ054VUw2UitHdWlNV0R1?=
 =?utf-8?B?bVR6YnhGeCtwRFQ4ZHQzcE1OQzlROHdsbVQrSnRBd0NDRWFTU3B1QjBWY0N3?=
 =?utf-8?B?OVoweEFJK082WmpUYlpNYTBld0ZoT1czMitxRTB3Um9oK2VNRitiT2lRcVEx?=
 =?utf-8?B?YnV3T0FVN2F5RmI5QWxENmlUeFZmalVQRzdnTUczUDRoanJRNVgwYnRYajEv?=
 =?utf-8?B?eVdiaERQNk1VMEppYU9CS2tJcSs3RTFRRTQvNThiTUtBZkNxK2t5bkVKb29O?=
 =?utf-8?B?MEVoRUkrRi8zRCtkQ0R3UE80RHlVV293c2NyTEcycERSWmN2cHJFWm9KVjdQ?=
 =?utf-8?B?aXFwMm93a1phSXBneVE0WEUyVHQxa0VjRStCL0ZrUW50aHRsTmVXM21MbXoy?=
 =?utf-8?B?dWh6Y0VPeFZTOGdPSWh5ZExSbktyRi9nTXBDOG5jYjR5R2oyYThXekJnL1JY?=
 =?utf-8?B?dnBXdllqL0lmb3VhQjkxamMwV0tBRDFFa0lPZHBJWmJYV1Y5NU9TWFBEQkZL?=
 =?utf-8?B?Ni85eFVaWGpGazBYdmhsSmlPUkJEbS93ZDZIY1B6cS81OGplcGZ1NlFZa012?=
 =?utf-8?B?bTJ1aTIyVTIzN2xsZUhvRUlDbUxTMWlsTG9ybW9MN25FQktNdXljUTg3cXJ5?=
 =?utf-8?B?NzF3WE1aVXJraEV0UkUzU0RVU1gyUjhQMG5TTjVjOVNDbVc1MktxTHVOWnBX?=
 =?utf-8?B?eGZJTFhMdURIQko2U0xuQy9PK3N6c2tnbHNiNERnMk9kdFZpV0krbTFCZ0NK?=
 =?utf-8?Q?VAyFmj88He1/AOAI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b75503d-3210-483e-6b13-08da23d9715f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 20:56:44.5031
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pNwQnuV4hQN60kvtue+wRiC9tvSsQSl781AidBA+UVasFC4701KXic90fsaCKpMOPwNZL2OCQi1g1b+Fm98hb5m81djvft4w74hBrAT5NpA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR10MB5430
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-21_05:2022-04-21,2022-04-21 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 malwarescore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204210109
X-Proofpoint-ORIG-GUID: LB7Mjm4hd-h4z4eMnMlT55yWtsHWyWh-
X-Proofpoint-GUID: LB7Mjm4hd-h4z4eMnMlT55yWtsHWyWh-
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 4/21/22 4:40 AM, Juergen Gross wrote:
> On 20.04.22 18:12, Boris Ostrovsky wrote:
>>
>> On 4/20/22 5:25 AM, Juergen Gross wrote:
>>> @@ -569,7 +645,7 @@ static void scsiback_device_action(struct vscsibk_pend *pending_req,
>>>       wait_for_completion(&pending_req->tmr_done);
>>>       err = (se_cmd->se_tmr_req->response == TMR_FUNCTION_COMPLETE) ?
>>> -        SUCCESS : FAILED;
>>> +        XEN_VSCSIIF_RSLT_RESET_SUCCESS : XEN_VSCSIIF_RSLT_RESET_FAILED;
>>>       scsiback_do_resp_with_sense(NULL, err, 0, pending_req);
>>>       transport_generic_free_cmd(&pending_req->se_cmd, 0);
>>
>>
>> You also want to initialize err to XEN_VSCSIIF_RSLT_RESET_FAILED.
>
> I did that.


Yes you did. I don't know what I was was looking at.


>
>> And also looking at invocations of scsiback_do_resp_with_sense() I think those may need to be adjusted as well.
>
> No, the invocations are fine, but scsiback_result() needs to pass through
> the lowest 16 bits instead of only the lowest 8 bits of the result value.
>

What I was thinking was that this could use the reverse of XEN_VSCSIIF_RSLT_HOST(), i.e. something like

#define RSLT_HOST_TO_XEN_VSCSIIF(x)   ((x)<<16)

to be explicit about namespaces.


BTW, should scsiback_result() use XEN_VSCSIIF_RSLT_HOST() at the top?


-boris