Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Nava kishore Manne <navam@xilinx.com>
To:     Joe Perches <joe@perches.com>, "mdf@kernel.org" <mdf@kernel.org>,
        "hao.wu@intel.com" <hao.wu@intel.com>,
        "yilun.xu@intel.com" <yilun.xu@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        Michal Simek <michals@xilinx.com>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, git <git@xilinx.com>
Subject: RE: [PATCH v4 2/5] fpga: fix for coding style issues
Thread-Topic: [PATCH v4 2/5] fpga: fix for coding style issues
Thread-Index: AQHYUZcjkgksvVyG0kSyIxbadyFg96zyw0MAgAKsDPA=
Date:   Mon, 18 Apr 2022 09:54:35 +0000
Message-ID: <SN6PR02MB45763D1B949353F99AAFE7D8C2F39@SN6PR02MB4576.namprd02.prod.outlook.com>
References: <20220416133719.3382895-1-nava.manne@xilinx.com>
         <20220416133719.3382895-3-nava.manne@xilinx.com>
 <ac22068dad06fd61f2e82c0bf7c0f58a4e5df050.camel@perches.com>
In-Reply-To: <ac22068dad06fd61f2e82c0bf7c0f58a4e5df050.camel@perches.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?raLm+WgCEuFlQWnRDFMludNdhTsWTQZkZtp1IMWzEFOQ7m76+kOmVRQ1j2lD?=
 =?us-ascii?Q?FJBsZqdAPS4yQY7HVudUNqojcEZWDl7u5j5R6T7fg9kbe/OLRb2gsDFQXFyP?=
 =?us-ascii?Q?q2uIf/ZCaRMzdOhV+Ic/G+PeTC/zCs5ANfMx1AdoJNqM6+ZWsrfmosMNQisw?=
 =?us-ascii?Q?DO7eVkUGWpKTQbCaIFrYrZ65/VWgWO6EYEro048o9eK1DQm+a30CYqYDIYPd?=
 =?us-ascii?Q?6kjTgxqCKbPNh/xPp18k+6OV7/xYpdM25xb6A61CNoXm2+hHWx7hI9taAriA?=
 =?us-ascii?Q?fn+JNldv0GSv03pAa1IwT/+5gEP38sE8htQypAfeBO8TNtIaF/gP/Xqe8Lrp?=
 =?us-ascii?Q?CIiaGbL0pStR+RUHZjDHL+5rVU+E01bYo1ypxqp0Aha74MidGYTiBlrM6RO3?=
 =?us-ascii?Q?y6LMFOP6fhGWTKLbx0jlymEy4+FUFIX8SrOuJuK7zqwGQs2LMKHYM1WdH/o1?=
 =?us-ascii?Q?8NuxSXfTCI2TT5yvp2TTi9YzjfhGXnCUZPCzsMTTiZqpdZTNaNqQhnmvt/6M?=
 =?us-ascii?Q?fZ5e3E+Qd9GTvC98dIiBMsQ7W8DN5HODYXhmePz0K8GQezqWrvLMMf/bzR/H?=
 =?us-ascii?Q?s1yvmD7BZBDq6WWPTyQnIQoqRpfZxKuWx6rAII5DNwRuQF+rknCxdJa+a5EP?=
 =?us-ascii?Q?qNVfZZYHigszew+7izyUH959q2fGx6axQ3LUTeEMOw/h6bpijud21edc3TnT?=
 =?us-ascii?Q?kXB0W7joWK0vBOHyuTFSlcz4A86vGcqIHZSQzj6CqBEVmtKqlapxTYVHjBGX?=
 =?us-ascii?Q?UoybqPN8oT7TK3FiubkBqTx77pEp/Kj7xWdiZG1BPY1pPjHp8oLjsYT9ujgO?=
 =?us-ascii?Q?+6uFrZIJdo2g+AEEXrf0O8IIVOeVihqEXj5mWNFmRkfroNiim+YhtAIc8jO7?=
 =?us-ascii?Q?87Fcx1EQRsIphg0wIbfnVWU/uRSSCye/hpMFjEOLQc5QuoR5QgrpeUtDvKek?=
 =?us-ascii?Q?tNUi0tobFO5aMpVc3FSfpf2/e47m0c111mB013QKtn7T6peH3zSKULINRPcw?=
 =?us-ascii?Q?/sBJ9g1Rl/NVoQ8YHjX15HoPVVLoNTKBuCbSbkkYAMTAoKppMHHbBsEOlnIb?=
 =?us-ascii?Q?GRcK7IeJzimEtQ9WQk+ffAZwiHnVMlDy6ZpA/ux72vZ29sLydosAeThaVU3N?=
 =?us-ascii?Q?Htk7t68oqB78zTG+I7OtQp0/eKQHaTcwHZJfwE3ds15KGTkC42uMAYR2yNIQ?=
 =?us-ascii?Q?ovHUGSy1DwM3wjsf4hMapFDrVZmdkFdJf1fmQmcCc/Nv3KF8RZGVzk3O7F3P?=
 =?us-ascii?Q?9XszbKwxMk6olJG6PzXNZkwB0r0f4KA1aHtq+QZ3c5fb9kH0z8pFqthTNpzW?=
 =?us-ascii?Q?PGknpLl87QHcwQyA0jOgiSPQ6vE5wSqukmR/YBT77PG4CDpiTMrQikvd/dyo?=
 =?us-ascii?Q?KVaUGnS+MSo9WdtBFgXd/Lka52cbfBpz/++RhESGEr9eY4ocbJvO3tTEMrOb?=
 =?us-ascii?Q?TpnOyEhRTtsr6Tw48dP3u64QXMSPCzgFdkn8bl0m+FS1dDMaswO4dMG8OIdQ?=
 =?us-ascii?Q?eD27h56/pz+LMWIzA1wXl+0zPjSLg8Pz32DUP2iVOx9Rr6BM/rpAgZFKpfGx?=
 =?us-ascii?Q?o343abu7ZyoWWyb186Cl4eabBDkKvu3JnCTvhuIYbEel7PFGdZXde2Kx8Q6U?=
 =?us-ascii?Q?7fecvBL8ymTc429+k9uieKwNjbaKEbYnPEGR745HfdzNaVSjmcmuK3IPhkUG?=
 =?us-ascii?Q?h6oKqkuvscRQ96DlLUYnwLXx7qnVmSgUZCj4ilnXHu5b8YsCWbZcPYH+Qvkw?=
 =?us-ascii?Q?vTgi32QeyQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4576.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0e76d32-3b75-4b19-dc33-08da212171f8
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2022 09:54:35.5649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: t1hT5HHn/EqkuI0UKhRT9zqC2fsKwN1lBElR42ycthCIdfwnsXkm5G6nbV1K48+8IsARXFV0duFiOJv8M/N5ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5559
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Joe,

	Please find my response inline.

> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Saturday, April 16, 2022 10:29 PM
> To: Nava kishore Manne <navam@xilinx.com>; mdf@kernel.org;
> hao.wu@intel.com; yilun.xu@intel.com; trix@redhat.com; Michal Simek
> <michals@xilinx.com>; linux-fpga@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; git
> <git@xilinx.com>
> Subject: Re: [PATCH v4 2/5] fpga: fix for coding style issues
>=20
> On Sat, 2022-04-16 at 19:07 +0530, Nava kishore Manne wrote:
> > fixes the below checks reported by checkpatch.pl Lines should not end
> > with a '('
> > Alignment should match open parenthesis
>=20
> in fpga-mgr:
> 	Another possibillty would be to change the function arguments
>=20
> and
>=20
> in fpga-region:
> 	Ideally keep the include declaration and definition styles synced
>=20

These changes are targeted to fix the checks reported by checkpatch.pl with=
out touching the actual functionality.

Regards,
Navakishore.