Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <6fcbe1e0-b011-7537-b61b-50bfe15f0ce5@os.amperecomputing.com>
Date:   Fri, 22 Apr 2022 11:17:08 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.0
Subject: Re: [PATCH v7 3/3] i2c: aspeed: Assert NAK when slave is busy
Content-Language: en-US
From:   Quan Nguyen <quan@os.amperecomputing.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Corey Minyard <minyard@acm.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Joel Stanley <joel@jms.id.au>,
        Andrew Jeffery <andrew@aj.id.au>,
        Brendan Higgins <brendanhiggins@google.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Wolfram Sang <wsa@kernel.org>,
        openipmi-developer@lists.sourceforge.net,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org
Cc:     Open Source Submission <patches@amperecomputing.com>,
        Phong Vo <phong@os.amperecomputing.com>,
        "Thang Q . Nguyen" <thang@os.amperecomputing.com>
References: <20220422040803.2524940-1-quan@os.amperecomputing.com>
 <20220422040803.2524940-4-quan@os.amperecomputing.com>
In-Reply-To: <20220422040803.2524940-4-quan@os.amperecomputing.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFFnZ0YxNUVmeGFlbGRvU00xTWk0TXJ5QXhIdDVRWGo2Y3l2L0tSNzRFcmcz?=
 =?utf-8?B?TlErb21NbndySDRqWTg0ZW1KWkRYUU1FbWNGT1p1aXRFQlhZaVJkM3lhMmJ0?=
 =?utf-8?B?anFJUEYrY2xuUzBFdWVLOHZhb1J3RnRyaUw1eWtvQ0kvd005UEppMm91UGRv?=
 =?utf-8?B?ZHdRbHlJVnZrWHBmWC9nYnhSY2paUmNsQVBnYlA5NjhMQjY0aWdEWDBFc3Rs?=
 =?utf-8?B?Ui9OUk9wZjhXV096eFc3d1dBUUIrOE5vdE54UkplWmd5dWFhQnp6TWEvMGlC?=
 =?utf-8?B?M3RnZ3BydU1LS3VjM1FWL0dlZXRqYzgxa1NYY2pPOTVNNUptd0d5aFJlbHg5?=
 =?utf-8?B?UUE2UGZjNFJBTFp3bjNaclJoNUdtbkNEMklJK25PeHJ5T3FiZFdPMCtmRENl?=
 =?utf-8?B?WmpWZCtsVTJ5dUVJaFJhWEQrbG12ODcyQ1RBSVNWQzhPTDlVdyt1a285S09t?=
 =?utf-8?B?NmR4eU1GS3ordXdjRzdUcGpHVVM1V2Y0NVBiYnlFNUZNS0pHYXVPbGczblRQ?=
 =?utf-8?B?Zks0K1AxUWtyMVlnbmdUZVBHZ2FrWlFoRjQ3dFJaZGh2UEdna1dGWGMyOWV2?=
 =?utf-8?B?V3MzK1dOVFBSZFY2VFpIMDNzQlhHVDdLQktrVk1UcVE1QVhlYjFqcXR3S1l5?=
 =?utf-8?B?eTRIWFBwNWMrZTNuZnFHaWdqTG1iWFZ2L3FYYURvVG1kZ2lHK2RvNVJQSTRq?=
 =?utf-8?B?cTVxc05DU0J5cHFFdWtYUk5XRDNPd0VJZGpGNlVoZlpJOTRzSHdqNXZzWng0?=
 =?utf-8?B?UStRTGY3NWxrTUVPMHVLaXJWTGF5ZVF3K3hsODN0d1RJZW5mcWNRcllieVdC?=
 =?utf-8?B?L21wZTg3QU40NDIxOVpWSkJGTElpVTB5MlVGbmZ0czgrcW9BOU91ZjU1Vy9s?=
 =?utf-8?B?Ykl4NnFkNU5BcW44amNsWktOQU5hZC9zblc5dmxaZXdibHRhZWQyS20xM2Iv?=
 =?utf-8?B?N2lFdmZIME5wWFVQbkYxYyswWHJHckRUenlXTFlJb0h3R2VTYSthUmt3U054?=
 =?utf-8?B?RUE1a3dSRkJtTTRYNlJZYjRwNzc4a3ZLbjNWL1BuWTFYc0w0VzYvRHlkWUtK?=
 =?utf-8?B?N2JCOXVKQlRhMkRZV3UrcWtZWHRNRVZXcjVTdG9kdFpSVmZESng0c200cHFE?=
 =?utf-8?B?ck40ZHUvTENQZk5zNlhnV1NERmZYN0RnOEYvWHJ2WVpHWEhzK2diVFFwTXBn?=
 =?utf-8?B?NDBlVFhxY2JHaUJ6K01jRis5VitLR0gzMXY4MWY0Q2hINVZMc003OVY2RCtY?=
 =?utf-8?B?M2krQ0V2Wmp0eno1T3RJbGpRR1creVBheDEzcWIwS0hFYk9YOXZxanc0WHNk?=
 =?utf-8?B?VlQzOFkxd01QV0dnU1F0M0J6dUxKaTkrYlU5ckJRcyt1cmRjWHdrZ2M3TWdm?=
 =?utf-8?B?TEpRZjRMU0JGOHM1MzdRMEpiT1pYcUphZ0FZY01UMXhaQURqa3dUOERJSjBh?=
 =?utf-8?B?NVRZRFNCZlV3eC9qaUdrWmhUSktPQldBdVZoOGlOWTd5a2hWN0RoeGR0QmlZ?=
 =?utf-8?B?YTM2Z1JsSVd2M2dTSVZaQXBqeWVhU0dsMUJQS1Jyc2phM1I2MEZ5WTRIclFE?=
 =?utf-8?B?dlc0TElVTnorOVVxNzNuU0U1VUVzK215QmlSVUYvTHZoUDFBTi9IN2dhZzdC?=
 =?utf-8?B?Q0ZPaWdSaEFaL3Q0L0ZBWjJXeXNvRDNTNkc3WmNQV1RkK09zTXFKWTVVL1dC?=
 =?utf-8?B?YlprVGl5dnhJaGpWY0IraW83dzhpbS9YVUkrOTQwVWdIbzFnT3pLOTF5QXBJ?=
 =?utf-8?B?d0lWRXRJYzBrV1RRL1V0Tzl2d3V3MHFnTU1CcjZKVW9GMDdibDN2cGYwd0k0?=
 =?utf-8?B?RHdBN216WDh1VGF4dldMM29wNjRrNHNKdWhndkk1azNNeitpOE5mL25vOHNt?=
 =?utf-8?B?TkNmaXBoNXRKUmZUTUt0MWJRWVZXdXRvVEE2YjBmYjBJdVUxd2g3Q2txM00z?=
 =?utf-8?B?bi84V3R6VEhhZHROMENPZlJFVFl2Mk1zNlFrZnhzbitXdzlIZlVvd1pDWlB3?=
 =?utf-8?B?dzI4UUxtVDNkUk5sUWoyUGQyKysvWllCMWQ2aTUxeHVSQ1kxSk1VQkFtaTJw?=
 =?utf-8?B?WFU3bUczYWwrN0pOZlVLK2NVSmd5ODVuR2hTUlV4QVUyWTJpMFhqR0l2NWVt?=
 =?utf-8?B?Y1NwMUdYdnlPd2JGaVIvQmNaSmpRU3E3U2EveStwZS9US3JtcGE3OGdHRVVV?=
 =?utf-8?B?aFZlWUR4ZnpVRCs4MkxlWS83cXdoV0g4bmdjMURoVlhwYjdhTnhvN2JhLzB1?=
 =?utf-8?B?WW9tTm55TWhOY24rUTA1Y2U0cVJmck81aHhSSjc4b3l2TnJoWTd0bjMzWGJi?=
 =?utf-8?B?N3lGUEZta0w0MTVvZ3o3OWpMcFozdzNXUU03M1lMdHZMY25Td25Hb2hnM0FH?=
 =?utf-8?Q?qhhnmajVyYEFzNPaP0W+k5OfO2aADM9i5yxZu?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9a2a244-7436-4722-5285-08da2416fd95
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR01MB7282.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 04:17:19.2084
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A9DWohszdBS51oM4HXuxEEqDFvNzCilHFO7lZe4OrVXcC/NkbWmtPk0qY/Qv4lSuCNBiJ7zpA4nsU7XgbU5QBi8qysVTzQh4K7XovZ6L7H4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR01MB2644
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Added Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
as I'm not aware of the email change
- Quan


On 22/04/2022 11:08, Quan Nguyen wrote:
> When processing I2C_SLAVE_WRITE_REQUESTED event, if slave returns
> -EBUSY, i2c controller should issue RxCmdLast command to assert NAK
> on the bus.
> 
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
> v7:
>    + None
> 
> v6:
>    + New introduced in v6                      [Quan]
> 
>   drivers/i2c/busses/i2c-aspeed.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
> index 771e53d3d197..ebc2b92656c8 100644
> --- a/drivers/i2c/busses/i2c-aspeed.c
> +++ b/drivers/i2c/busses/i2c-aspeed.c
> @@ -244,6 +244,7 @@ static u32 aspeed_i2c_slave_irq(struct aspeed_i2c_bus *bus, u32 irq_status)
>   	u32 command, irq_handled = 0;
>   	struct i2c_client *slave = bus->slave;
>   	u8 value;
> +	int ret;
>   
>   	if (!slave)
>   		return 0;
> @@ -311,7 +312,9 @@ static u32 aspeed_i2c_slave_irq(struct aspeed_i2c_bus *bus, u32 irq_status)
>   		break;
>   	case ASPEED_I2C_SLAVE_WRITE_REQUESTED:
>   		bus->slave_state = ASPEED_I2C_SLAVE_WRITE_RECEIVED;
> -		i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> +		ret = i2c_slave_event(slave, I2C_SLAVE_WRITE_REQUESTED, &value);
> +		if (ret == -EBUSY)
> +			writel(ASPEED_I2CD_M_S_RX_CMD_LAST, bus->base + ASPEED_I2C_CMD_REG);
>   		break;
>   	case ASPEED_I2C_SLAVE_WRITE_RECEIVED:
>   		i2c_slave_event(slave, I2C_SLAVE_WRITE_RECEIVED, &value);