Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 21 Apr 2022 10:14:03 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc:     "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Christoph Hellwig <hch@lst.de>,
        Alex Williamson <alex.williamson@redhat.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PULL v2] gvt-next
Message-ID: <20220421131403.GF2120790@nvidia.com>
References: <5a8b9f48-2c32-8177-1c18-e3bd7bfde558@intel.com>
 <20220420164351.GC2120790@nvidia.com>
 <20220420114033.7f8b57c7.alex.williamson@redhat.com>
 <20220420174600.GD2120790@nvidia.com>
 <20220420200034.GE2120790@nvidia.com>
 <55cb46db-754e-e339-178c-0a2cfaf65810@intel.com>
 <20220421054738.GA20772@lst.de>
 <165052329083.6597.933445971686511585@jlahtine-mobl.ger.corp.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <165052329083.6597.933445971686511585@jlahtine-mobl.ger.corp.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+DJWBYUwXIxjOT4xhkz40soHxdeladFEdVP39+TZB4WQUUKwikcQX2p7BsoA?=
 =?us-ascii?Q?9FnFMbmF+VN8E61xc1IuoxC0/GD/mT/6pWXzDT9zXUAwYysZPXsY+2cSpA0w?=
 =?us-ascii?Q?xcRJ3/i0VGBPI8tkxV+D/kw/ZwbYaZ2PqOqhpOytEHJX/pU+9AiDxDjHMHhd?=
 =?us-ascii?Q?hn82SkH9FXixWQTCqAwwpQwcKxHYJybqWuNovwvL+3rBpNX5zcNQGKLi5WQH?=
 =?us-ascii?Q?gFp4FNeAlI9rQY/3YL/N1TXefyR25xJw17gAwrVoj1+gyMPCbXXNofS7EgwH?=
 =?us-ascii?Q?vBI6Q+OGedCMWN2uQrrG02l6QzjydEo/g7syOSmN4osp0hqzHspxVJCnHQSs?=
 =?us-ascii?Q?mdv/fXqrbKxRhsb0NY18yX7V2M8YsDSsuP7b8T+8K0JP141qcQmt/FJAcT2z?=
 =?us-ascii?Q?V6rmbYBWUH0kuq6ICY46/W9WkXQ8o+d59WUwX3xvcA35ixp27jCnpSB7yXgZ?=
 =?us-ascii?Q?szWX5pMqAOHXZmVqiC0GdmwGkjR0THXNObRe74hMCoBDZQtO2VoJ2TVeUE68?=
 =?us-ascii?Q?vOaRLqRSXSOi5X7B8YYdqdpF2jCfwZbrS6SX8mfzIvYJ+63xMtz2M9Kt4GrG?=
 =?us-ascii?Q?f1Sj3LpgW9w8vuFpin8Jg1pR1hDrVWIgZek/ZiQJx/92WUWUBjEAiWH8/tTg?=
 =?us-ascii?Q?zUC00sjUlQgfCRvc/4F1vcKdPGB/v7Z5zVEgO3NIrDuQe3Flf7ZEhzCvYGec?=
 =?us-ascii?Q?Yn2moq/MIXE9xCuP05xgbZFqf3tx0N08WZ9USf3OGFYlayhbN0cXxvfPGQcL?=
 =?us-ascii?Q?IxTU8bfeBZ3cF+fTI6ho7DsPtJkrl2X8beUL0l9grd5EYRyyvYZdmCtuTTun?=
 =?us-ascii?Q?Nv9enbbbJvzETjuFltmClKrfbyE/4RPQktSMx3u6/pEoduunXEhzUsKhMlGR?=
 =?us-ascii?Q?IiRy3PrFiaXlbfLdK/f8fad87v0jn6BXaY734qIQSrltilyNSHF1neWDHFdW?=
 =?us-ascii?Q?NbRs/kb9ipOBCYaAublCqxxdqMsBD8p2ZAwVWTL/bs30McC9tGmHHrC61L3i?=
 =?us-ascii?Q?V9hRa1TYM+zq3yzA6l6tQ+hRMB2QcipGUc/XxxVpGAppdYYRPDf4Vx43tFg5?=
 =?us-ascii?Q?aqcFxkwBvSKd7bMIQQy9YRa0jBgaroc/t/D+m+U1yqL/4O93TErzjk/8y3wf?=
 =?us-ascii?Q?TkjX24k5BMELLYvwuD45s0NWWSswKbmPFa2WrkHWl7O0ArMvWhHXzJ5PnuIc?=
 =?us-ascii?Q?9JfxscoiR+M4+ZW17DgUtPS86drjlFpsZgOF+UGCmKNoPVHd66rjX3qkkbnh?=
 =?us-ascii?Q?XOnDjaXO8CdTzvXj6PmTMjWyS+Yb1OyZUgCk9gKZhgXcf849xb1I/uyLIus+?=
 =?us-ascii?Q?Rcb+87zjuJSz8rNBLggR8gnBX4Ev4fQJtG9IgANBEczx0KnXqEYKKR/t2F2O?=
 =?us-ascii?Q?bbB+TqZqeI7U0x0Rc7OSAyhA8O1S7/WS55EqjnNwcO1wdZanEbg7r2sGCUWl?=
 =?us-ascii?Q?AAFytcyppCzxN8vVrXnudSKYjtTdewRYaIvmfNj/YjYVJ7ah/71agGlhxsvE?=
 =?us-ascii?Q?6t+NZlIbn39G3vuUW1vn9oboaQfOawUUrqTu9AmCVq1V8D1IcpnwZ4r2AGDw?=
 =?us-ascii?Q?6hIfl4Il9QwoDyw/D7lCdVEyYJbs90vg70Iy9BDhkUjY1YlfcTiZMUzjvKCY?=
 =?us-ascii?Q?wHxta6efEUU7g3Xbi+Ga2jQe2OJltZEYcc0NPGTT8sgYEgr94SMx7i0NCcqc?=
 =?us-ascii?Q?jnbJzejM3FV2TfUqkblfShggWRnrm+g+TKg2A2/Mn+M5rPytmwJjBAsBXdAs?=
 =?us-ascii?Q?Xn574oo2Ng=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a0d2281b-9742-4bbe-8721-08da2398cf3a
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 13:14:04.9610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a9j+ug00veX8URcmHy2Lfue+Vap1jcZx/B1xJECUSAR05eVbuMzUFSmcISBn1dlv
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5840
X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 21, 2022 at 09:41:30AM +0300, Joonas Lahtinen wrote:
> + Tvrtko
> 
> Quoting Christoph Hellwig (2022-04-21 08:47:38)
> > On Thu, Apr 21, 2022 at 04:57:34AM +0000, Wang, Zhi A wrote:
> > > Is it possible that I can send two different pull based on the same branch?
> > > I was thinking I can remove this line in the original patch and then add a
> > > small patch to add this line back on the top. Then make two different tags
> > > before and after that small patch, send one pull with tag that includes that
> > > small patch to i915 and the other pull with tag that doesn't includes it to
> > > VFIO?
> > 
> > Yes, you can do that as long as the small fixup commit is the very last
> > one.

Keep in mind when doing this that best practice is for every commit to
compile.

So if you add a commit with a new #include to this topic branch that
commit will not compile.

Best practice is to fix the compilation breakage in a merge commit,
either created by you or created by your upstream.

Jason