Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <e4c9bb60-210d-243a-e225-6b3546c0b42b@leemhuis.info>
Date:   Fri, 22 Apr 2022 16:17:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Content-Language: en-US
To:     Takashi Iwai <tiwai@suse.de>
Cc:     Shreeya Patel <shreeya.patel@collabora.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        regressions@lists.linux.dev,
        Mario Limonciello <mario.limonciello@amd.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>
References: <s5ha6cdtglj.wl-tiwai@suse.de>
From:   Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [REGRESSION] Missing IRQ via amd_gpio
In-Reply-To: <s5ha6cdtglj.wl-tiwai@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Takashi! Thx for CCing the regression list.

On 22.04.22 15:03, Takashi Iwai wrote:
> Hi,
> 
> we received a bug report for 5.17.3 kernel showing a new error:
> 
>  amd_gpio AMDI0030:00: Failed to translate GPIO pin 0x003D to IRQ, err -517
> 
> Not only an error message but in practice this leads to a missing IRQ
> assignment; the IRQ 27 is no longer assigned to amd_gpio driver.
> 
> As the error number (EPROBE_DEFER) indicates, this seems to be the
> side-effect of the recent fix, the upstream commit 5467801f1fcb
> ("gpio: Restrict usage of GPIO chip irq members before
> initialization").  As far as I understand, the problem is in
> acpi_gpiochip_request_interrupts() call that is called from
> gpiochip_add_irqchip() itself.  Since it's called before the
> initialized flag set, it always fails now.
> 
> Below is a temporary quick fix and it seems working.  But I'm not sure
> whether I overlooked something obvious...

A patch that afaics will fix this hopefully should get merged really
soon now:

https://lore.kernel.org/all/20220422131452.20757-1-mario.limonciello@amd.com/

See also v1:

https://lore.kernel.org/all/20220414025705.598-1-mario.limonciello@amd.com/

Ciao, Thorsten