Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp820519pxb; Fri, 22 Apr 2022 11:54:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1slz/YBzQ96CajmtmuxZpT3H55chErHe0YjM7x3MTOyiSnQ3/ztELOgQrAbGxipSN7fR7 X-Received: by 2002:a17:902:a712:b0:158:9e75:686c with SMTP id w18-20020a170902a71200b001589e75686cmr6310166plq.56.1650653642435; Fri, 22 Apr 2022 11:54:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650653642; cv=none; d=google.com; s=arc-20160816; b=Lb8giLgfFxLoMr1bxRtLWsd1P5Er1AtCYUlMxLzsQH3H0PKF2TNZv5RL6PkVVhBV5V 6465OeeI4YtZmqcOgqfcV8a8EDtj2TzvTy+KDr6O1S6o1X4f6F+XZRR74bXUPegqBK9D qWyFTuKkxAfs2CwGKNxrSgo5eBRx+ytB4Btmjqh1VJy8/CKGUN78Eqv9D5clhmZ4wXUn N5YDjvlPTEzOoOVBc/nooYDO2G9qmRYAJ9MJouU1PDKBThiuyF43pWiaRSuPX2fqChEU J5ZDwoPgAiCqoiuM+eGU4A4BWrn6lBiuR6RtS02Q6uZY3qxUhCtXvjAZl/xRDlcy0HCP emxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=teOH439CL13s2Fik94mdeuFW3qMai2ULGSkcDlXTTO0=; b=GAq3K7bX7ROGdKRhiv2tD/kpplU+6KyuMM7hDGUdO8tdD7W581KDGt9D1gI8+vnr8G bKoX5jRg4RwrE4vXIHr98AdiPtLzOAWhXMA5e72MbvrPgZqOJ3jmHg/Bn+R2g9M1t3hw F9DK55ez7ZaUZv6kkneHc2J7A2sJHVg7/FGoCkFQBgQ9DldUpH8r343LrUCYUiXTCpBV MadBHPJjt+662zSZDYOUo4hfckhn9tB56jIE9sKLN6x3vYlzIpEH16r+V+i4239zmgg+ rEx0nL4wPU7IBz//H/TBdd2spBz+l8xiuHxh0BBbzlmcRtXqFFj6gKSeimuSIKRhJgNL DAWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=jhxORQd7; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id be3-20020a170902aa0300b00153b2d165c7si8821570plb.463.2022.04.22.11.54.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:54:02 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=jhxORQd7; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 928E4137DA7; Fri, 22 Apr 2022 11:18:14 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446550AbiDVKak (ORCPT + 99 others); Fri, 22 Apr 2022 06:30:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446540AbiDVKag (ORCPT ); Fri, 22 Apr 2022 06:30:36 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2910D54BF5; Fri, 22 Apr 2022 03:27:42 -0700 (PDT) Date: Fri, 22 Apr 2022 10:27:40 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1650623261; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=teOH439CL13s2Fik94mdeuFW3qMai2ULGSkcDlXTTO0=; b=jhxORQd73g5jY3hX9HNBFt8Ve3WdXFS5uc2PYmxPKkqYTupJIQBvX1KGorx2B/Tw+s4F/F 7+dGVzfI/gV0McAcm0B3JIerzNYQ8lCqpq9Bh5caQBW5fdoH1ukTsWwRNMv94uQTiICzLt 03XD+JotRRwH2c6dbABqycdrCJF4RC9sbGamFUBPFLSR7VUvw5c0/du7vu4SPWZ1gdHkeA 7XMgFiiX2V7XWMAEYrCXbCAAOxekCV0+ELo7Gh1INSt4qhlQrvRZ/jhlJ9Y0zXqXSKZllU X+7TYu/HTdOU0SBeAH40WbQq8R6x8zzI2YqGSSsWpesRCRzc3P1xsHgkMWo++A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1650623261; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=teOH439CL13s2Fik94mdeuFW3qMai2ULGSkcDlXTTO0=; b=c8NqAdYfu7i97oIFkpVvThhfBnqncQpy2L4yW049ji8kqWmjNF/YhIoVa2Plp5cgXZpWt5 y3o5pRczKMI2QFBw== From: "tip-bot2 for Tao Zhou" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: sched/core] sched/fair: Revise comment about lb decision matrix Cc: Tao Zhou , "Peter Zijlstra (Intel)" , Dietmar Eggemann , Vincent Guittot , x86@kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20220415095505.7765-1-tao.zhou@linux.dev> References: <20220415095505.7765-1-tao.zhou@linux.dev> MIME-Version: 1.0 Message-ID: <165062326028.4207.17060214721845047142.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the sched/core branch of tip: Commit-ID: a658353167bf2ea6052cee071dbcc13e0f229dc9 Gitweb: https://git.kernel.org/tip/a658353167bf2ea6052cee071dbcc13e0f229dc9 Author: Tao Zhou AuthorDate: Fri, 15 Apr 2022 17:55:04 +08:00 Committer: Peter Zijlstra CommitterDate: Fri, 22 Apr 2022 12:14:08 +02:00 sched/fair: Revise comment about lb decision matrix If busiest group type is group_misfit_task, the local group type must be group_has_spare according to below code in update_sd_pick_busiest(): if (sgs->group_type == group_misfit_task && (!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) || sds->local_stat.group_type != group_has_spare)) return false; group type imbalanced and overloaded and fully_busy are filtered in here. misfit and asym are filtered before in update_sg_lb_stats(). So, change the decision matrix to: busiest \ local has_spare fully_busy misfit asym imbalanced overloaded has_spare nr_idle balanced N/A N/A balanced balanced fully_busy nr_idle nr_idle N/A N/A balanced balanced misfit_task force N/A N/A N/A *N/A* *N/A* asym_packing force force N/A N/A force force imbalanced force force N/A N/A force force overloaded force force N/A N/A force avg_load Fixes: 0b0695f2b34a ("sched/fair: Rework load_balance()") Signed-off-by: Tao Zhou Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Dietmar Eggemann Reviewed-by: Vincent Guittot Link: https://lkml.kernel.org/r/20220415095505.7765-1-tao.zhou@linux.dev --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 3eba0dc..4c42012 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9496,7 +9496,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s * busiest \ local has_spare fully_busy misfit asym imbalanced overloaded * has_spare nr_idle balanced N/A N/A balanced balanced * fully_busy nr_idle nr_idle N/A N/A balanced balanced - * misfit_task force N/A N/A N/A force force + * misfit_task force N/A N/A N/A N/A N/A * asym_packing force force N/A N/A force force * imbalanced force force N/A N/A force force * overloaded force force N/A N/A force avg_load