Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp820688pxb; Fri, 22 Apr 2022 11:54:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwr7qNA4JX8t3BL/F4eSgxTQdBpT5stlUL6VKSR1//xzTbnFOa/io6AxDx+3mqUzYwtxbzP X-Received: by 2002:a05:6a00:1145:b0:4f6:3ebc:a79b with SMTP id b5-20020a056a00114500b004f63ebca79bmr6487984pfm.41.1650653655889; Fri, 22 Apr 2022 11:54:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650653655; cv=none; d=google.com; s=arc-20160816; b=bk05ETKMydInMh/tBeKPD0acLNxKR1HLsdQSx1fGd4Igx6U8TWMi0jdHkhQB1pP4dk lMQxFxl4ZiCa+87OSyiM0dlv/30FWaPJ8rYNKf8etUDWj8oqAU8ncu2stQ+h7O90xjmh qEhgDsi7Ec/mvB+wfTLlbf6+5G7PgLqymfEAsiIeIkar804yCucztCIFWqzV4kXvI1+8 rRWv5AOz224XBngEV4/wa7RK5uIsIzYB5xmBNoWjWEe7ndXNtI8bPiPoZ+fvRCY2DHhn J/7E/AbB/kHomUrUQ9eITzK6Sh1L3pyNaD/RaNXi7x3Hw/4qN631UhDu1l2cmg/jy9EA +QTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=igYFGVwUtMrYFtCOVyOEziT54htNgcX7DvW0MJFZu8I=; b=zsYTMOzpMIuY2tGXMf+WBq4T/OD50CFKcaUV9W1nqqWmvsvrhF22fq3MekJkOg/TJh cJBjVd/oDcuU/Eto1z+M/V+7eRfhZqFbLCzNt0YSjwOHguyNzMQwfmEI9dzh9Poi2Wne Q34Zkpt3QFtQGWWjokSgWfAwEdt2rF/3OSfXNNcInYyIqDiOVpodNTZNUfVlCt9Rk+Y5 srzQLSW+BbjmCX4oKP2lRBxP95eOm7n7a9W+Nn6doT8P/xVynZVs+CS4hDUfjGhLOKom DZsWxaHI5vb69yjrwZCogfIh7hCLTridc4kBqUEafpz3ieL38xdzkkJWFPHZddrcRj1e 6zzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DdBFOPQK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id b16-20020a170903229000b00158695aa2efsi1362767plh.200.2022.04.22.11.54.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 11:54:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DdBFOPQK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6520517FBE9; Fri, 22 Apr 2022 11:18:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381443AbiDTSOu (ORCPT + 99 others); Wed, 20 Apr 2022 14:14:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345342AbiDTSOt (ORCPT ); Wed, 20 Apr 2022 14:14:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A2E446B0E for ; Wed, 20 Apr 2022 11:12:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBC0B61B44 for ; Wed, 20 Apr 2022 18:12:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A071C385A0; Wed, 20 Apr 2022 18:12:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1650478322; bh=NTy9pFDWRuCUyy+uRS6JtLFaKO2Z2cLw81UXIFC+Vr4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DdBFOPQKPs5WI1dCKZuS5WAuu77VokqeMbZM5eTxoTWfi+tZDeOdFOBl/exLtmrE/ 50q2oNjj7F2e547EfrKKG5jMin0+lWpjlUGv65p3WMbp3NxnN+tk1WAmotlyvsci+P kpnuCskiQbDl7HubYrAeF9HUiDZ6c0hdK29vtZaTebAxvE9p6AHY1c1D/a3YeV5SRG kYhJ1SmaMyOEyQ/InoqZjNrwLMzvIPqbd5onUlptLNKS1zH2vd+9j96oX2K2sriXKe 9yIuO7woiJuruLrI5YjaQ/C4LMguzLYyex44KpqiW5QPHpUEzKgjspdeHTljRuOuK1 2oxBEZtax11BQ== Date: Wed, 20 Apr 2022 11:12:00 -0700 From: Jaegeuk Kim To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH] f2fs: use flush command instead of FUA for zoned device Message-ID: References: <20220419215703.1271395-1-jaegeuk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19, Christoph Hellwig wrote: > On Tue, Apr 19, 2022 at 02:57:03PM -0700, Jaegeuk Kim wrote: > > The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush > > command to keep the write order. > > The block layer can reorder all commands. Given that FUA only affects > the command itself that should not matter. What is this trying to fix? Not for zoned disk, as I mentioned. The mq-deadline serializes write commands but I got an reordered command, if there's a FUA|PREFLUSH command, which emits EIO by the disk.