Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp830935pxb; Fri, 22 Apr 2022 12:06:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRo8uTgXkdmaApuyx1sA4vM/18WRtvUOEQx0VP/J30qxf4MIfgsnVbGGrOeyTFlAdH/t82 X-Received: by 2002:a62:1611:0:b0:50a:41c5:e6fc with SMTP id 17-20020a621611000000b0050a41c5e6fcmr6485313pfw.35.1650654405015; Fri, 22 Apr 2022 12:06:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650654405; cv=none; d=google.com; s=arc-20160816; b=pI5S+4lbYS4SECtEOgn/HSgeo8iLgxiyZL8GIENZgJGcEocss1l3kz6L3A3H7MByzh ZgJcc5hoNVtS50175rsInAmIY7FVKcdFa2r0rfF25Q0smYbyKZRhU0k0zUI6dNBokoMR 3ZyMSnlIhrAlRT207615C9cmWgNa3J17afJoohIKTznxz9jyF2PTlt8zyeX/ZxKsztyV 7r1xItrFVqzVo2B3l+LQ00uWQS9y3JcMK8aR5hZ+MJzbJKjX6SL2tWvfdMZxQdJI2DJa m14V7SDm6W+uF5y2hLRv5FTFJYeqQQd7RD9jQ/c0k5VbgsPzl8cCHo56fjO3/VqvI7OH NKhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Nw6tNzQpsXOvVmB62NVDYsybZn52u7DxMcOdKt0YWkw=; b=N1MO1QGW5kNuTTGYQExVTqQxT2TadaStHcv1fVZ/UqlAT84XhHhQnWd02cCC+AWxzx 1mcQ1V83PT/fPEKjW66iHA+GIhAQmTTdIIXl/pqGGHi7W025kKA4Fl4q6KgsH4/eSEEs cwahNOuDuNrlBNH2ZPgMd918hOoszJBaBR15npI4buaBcgKG6w7QjW/+x/xsxXfzbWp/ k5Onh9WxPconjvzhAcBmo41ZWonbMlHKVQ9TOOpIeNrPUTy7rBy9+MsRTjyAP9//pTf/ /Q7SKJLVRg8a53Qevcq5r0OCPZEjWUUJG2amxTUvuarhqTVgz+NC9GVwsirvm+hQJcP9 No6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X7jLxxtV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q20-20020a656a94000000b003aae09215a1si973561pgu.850.2022.04.22.12.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 12:06:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=X7jLxxtV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 37B1219A4BA; Fri, 22 Apr 2022 11:26:18 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381624AbiDTTHs (ORCPT + 99 others); Wed, 20 Apr 2022 15:07:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244725AbiDTTHq (ORCPT ); Wed, 20 Apr 2022 15:07:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39AC52DCF; Wed, 20 Apr 2022 12:04:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CB4926130A; Wed, 20 Apr 2022 19:04:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7826C385A1; Wed, 20 Apr 2022 19:04:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1650481498; bh=3TwvUFV0aw9LmXxpaVt1WobXYjRRbhKrWPYqHzWsKv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X7jLxxtVlTztqVg3E8BIUuuDLZKMM2mTqRwnBiVXErc194bnvswjXEBu4V/EHgeHP lzyz9hJhEA9hex7EsRngiu1T0KU677Hoq/3jgOQV3/+r0bxHXVAKpp9uVkCBC9kg8E G4OV5/xcOVd8fTONZl9Nhl9pXMfbDmxy0pC78wzI= Date: Wed, 20 Apr 2022 21:04:55 +0200 From: Greg KH To: "Luck, Tony" Cc: "Williams, Dan J" , Hans de Goede , "markgross@kernel.org" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , X86 ML , "H. Peter Anvin" , Jonathan Corbet , Andy Shevchenko , "Joseph, Jithu" , "Raj, Ashok" , Steven Rostedt , Linux Kernel Mailing List , Linux Doc Mailing List , "platform-driver-x86@vger.kernel.org" , "patches@lists.linux.dev" , "Shankar, Ravi V" Subject: Re: [PATCH v3 03/11] platform/x86/intel/ifs: Create device for Intel IFS (In Field Scan) Message-ID: References: <20220419163859.2228874-1-tony.luck@intel.com> <20220419163859.2228874-4-tony.luck@intel.com> <578be5d8874f4942a58adf5f64c4e817@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 20, 2022 at 06:08:20PM +0000, Luck, Tony wrote: > >> Or is it ok for them all to sit at the top level of /sys/devices/virtual? > > > > How many do you have? > > > > And why is a directory needed for just one tiny driver type? > > One today. Two tomorrow (internally ... next gen CPU). > > Three eventually (That's how many are on the roadmap that I can see). Then just use a misc device, it's simple and saves you a ton of code.