Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp831421pxb; Fri, 22 Apr 2022 12:07:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyktCU035Qpy2lbVoacaPqu1d63/AJUS23vfM2s5htQZYdqDrV7UNhqHIjfY/HKT3DWpGR/ X-Received: by 2002:a17:902:d50c:b0:159:3fa:266 with SMTP id b12-20020a170902d50c00b0015903fa0266mr6071506plg.132.1650654438220; Fri, 22 Apr 2022 12:07:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650654438; cv=none; d=google.com; s=arc-20160816; b=VkM9tUS3PVv9nq3b83mBmohvowcHSKnF3HtGPWSzna6XWe8sgyxFezSWl/UD/7Fr4P BXfHQnPGnkXw15xsOfmH68Rq2uxdNKH25eqUe7ryVHiE7yBqhnqQNQ1UaLFPPAnPhkC4 cuMcRWRdoMsHiz+hlbiQXl7vHlL6JXY5LQAWljDqPifTmOLcCbf2ooImSBN8pKdcimPL 3mqwCcBQ3nua0voyMYtuwn3FECifbPfbdSZdBgz/kILk0TDux5bG5uEa0KNPIeIX1gjv go5/1pFJ8SOiDFaCoiAwWLYkkBzqh9bbnEPciGYRr+EnsvdZ+KqutgKy3QIvEg4HQU00 oCrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=7WnoHFvC+Jw4yrwC2+57HbuHk5I24tE+HQ9CEpvMcJY=; b=CdKY+8UO78R7mvzp2O9ki03/5db/YQCmdGCT+5a/BoCY6rhmQgtZ1FC67nDCSHJR1j hMgZm42BBpl9L6sG8aI51mCLjhB3cGR24WvhYdNDXlith4rObBBaRpXD7YhBxVcQgdKP iTdgntlZI3VotoJmCbWzXEqj3lZHUeY6IBCOfMgaY5AeOig3HbNC9r1BayC1CK0Qg1LT zhK76ahP86kky39LQvaI3qBvoeRox957PAnL80bilAzTvAg7m6SA5JzCfhwXGw2Mhdgh Ic+nmVCkNAVamJh1oNP5LjCRx4wdTZctOHWC7OTHg3Z5urMN/fMHPPu9O5HHNM9B+bXL vNhA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id a38-20020a631a66000000b003991d7df4b8si8972531pgm.652.2022.04.22.12.07.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 12:07:18 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 11E0214A533; Fri, 22 Apr 2022 11:26:42 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1387658AbiDUJbm (ORCPT + 99 others); Thu, 21 Apr 2022 05:31:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1387657AbiDUJbk (ORCPT ); Thu, 21 Apr 2022 05:31:40 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F769286D7; Thu, 21 Apr 2022 02:28:50 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 21 Apr 2022 17:28:50 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Apr 2022 17:28:48 +0800 From: Haowen Bai To: Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , "Martin K. Petersen" CC: Haowen Bai , , Subject: [PATCH] scsi: bfa: Drop redundant memset Date: Thu, 21 Apr 2022 17:28:47 +0800 Message-ID: <1650533327-29396-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The region set by the call to memset is immediately overwritten by the subsequent call to memcpy. So we drop redundant memset. Signed-off-by: Haowen Bai --- drivers/scsi/bfa/bfa_ioc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 5740302d83ac..2227e46a4813 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -2748,7 +2748,6 @@ bfa_ioc_get_type(struct bfa_ioc_s *ioc) void bfa_ioc_get_adapter_serial_num(struct bfa_ioc_s *ioc, char *serial_num) { - memset((void *)serial_num, 0, BFA_ADAPTER_SERIAL_NUM_LEN); memcpy((void *)serial_num, (void *)ioc->attr->brcd_serialnum, BFA_ADAPTER_SERIAL_NUM_LEN); @@ -2757,7 +2756,6 @@ bfa_ioc_get_adapter_serial_num(struct bfa_ioc_s *ioc, char *serial_num) void bfa_ioc_get_adapter_fw_ver(struct bfa_ioc_s *ioc, char *fw_ver) { - memset((void *)fw_ver, 0, BFA_VERSION_LEN); memcpy(fw_ver, ioc->attr->fw_version, BFA_VERSION_LEN); } -- 2.7.4