Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220421013920.3503034-1-zheyuma97@gmail.com> <e29fd64e-62ea-746e-f0fb-02ce86b4e61e@opensource.wdc.com>
In-Reply-To: <e29fd64e-62ea-746e-f0fb-02ce86b4e61e@opensource.wdc.com>
From:   Zheyu Ma <zheyuma97@gmail.com>
Date:   Fri, 22 Apr 2022 09:50:24 +0800
Message-ID: <CAMhUBj=fpQi1uvkSQg7vuefLOsxxEgM5fTfsNu1w2sWmvybO0Q@mail.gmail.com>
Subject: Re: [PATCH v2] ata: pata_marvell: Check the 'bmdma_addr' beforing reading
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc:     Sergey Shtylyov <s.shtylyov@omp.ru>, linux-ide@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Apr 22, 2022 at 7:48 AM Damien Le Moal
<damien.lemoal@opensource.wdc.com> wrote:
>
> On 4/21/22 10:39, Zheyu Ma wrote:
> > Before detecting the cable type on the dma bar, the driver should check
> > whether the 'bmdma_addr' is zero, which means the adapter does not
> > support DMA, otherwise we will get the following error:
> >
> > [    5.146634] Bad IO access at port 0x1 (return inb(port))
> > [    5.147206] WARNING: CPU: 2 PID: 303 at lib/iomap.c:44 ioread8+0x4a/0x60
> > [    5.150856] RIP: 0010:ioread8+0x4a/0x60
> > [    5.160238] Call Trace:
> > [    5.160470]  <TASK>
> > [    5.160674]  marvell_cable_detect+0x6e/0xc0 [pata_marvell]
> > [    5.161728]  ata_eh_recover+0x3520/0x6cc0
> > [    5.168075]  ata_do_eh+0x49/0x3c0
> >
> > Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> > ---Changes in v2:
> >      - Delete the useless 'else'
>
> Note for future contributions: The change log should be placed *after*
> the "---" that comes before the "diff" line below. Otherwise, the change
> log pollutes the commit message.

Thank you for the reminder, I'll pay attention to this problem next time!

Zheyu Ma