Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 21 Apr 2022 13:40:02 -0700 (PDT)
From:   "Kenneth R. Crudup" <kenny@panix.com>
Reply-To: "Kenneth R. Crudup" <kenny@panix.com>
To:     Kai-Heng Feng <kai.heng.feng@canonical.com>
cc:     Bjorn Helgaas <helgaas@kernel.org>,
        Vidya Sagar <vidyas@nvidia.com>, bhelgaas@google.com,
        lorenzo.pieralisi@arm.com, hkallweit1@gmail.com,
        wangxiongfeng2@huawei.com, mika.westerberg@linux.intel.com,
        chris.packham@alliedtelesis.co.nz, yangyicong@hisilicon.com,
        treding@nvidia.com, jonathanh@nvidia.com, abhsahu@nvidia.com,
        sagupta@nvidia.com, linux-pci@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com,
        Ricky Wu <ricky_wu@realtek.com>,
        Rajat Jain <rajatja@google.com>,
        Prasad Malisetty <quic_pmaliset@quicinc.com>,
        Victor Ding <victording@google.com>,
        "Kenneth R. Crudup" <kenny@panix.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for
 suspend/resume
In-Reply-To: <CAAd53p6jh7Jx3pzg9TzrSrW8+3pzLN6EBAFjFv+7T4tMODmX+g@mail.gmail.com>
Message-ID: <42f9a28-e67-ec2a-f6-9a8b58edd84d@panix.com>
References: <CAAd53p6DX2C7KVRV=uu_mmPTTjE7=RsXfNPxjbOBLRbf-pXi5A@mail.gmail.com> <20220415212533.GA844147@bhelgaas> <CAAd53p6jh7Jx3pzg9TzrSrW8+3pzLN6EBAFjFv+7T4tMODmX+g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk


On Thu, 21 Apr 2022, Kai-Heng Feng wrote:

> I went through the whole discussion again, maybe Kenneth's case is
> also the result of pcie_aspm_pm_state_change()?

> Since Kenneth is using TLP to switch ASPM between performance and
> powersaving/powersupersaving, that means 'aspm_disabled' is false.
> Hence the KOXIA NVMe stops working post suspend and Realtek card
> reader toggles L1ss post hibernation.

> Kenneth, can you please see if removing pcie_aspm_pm_state_change()
> from pci_raw_set_power_state() helps?
> Anyway, this can be easier to spot if dmesg was attached.

Well, I haven't had an issue with resume/return from hibernate for quite some
time, and the patch I'd reported a long time ago is now in the Linus' master
I've been running. I believe a BIOS change from Dell fixed it up for me.

But if you're looking for information in any case, I could still do this and
get back to the topic re: the results.

	-Kenny

-- 
Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA