Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <736b71d7-1e07-f5c3-d8ad-c3e1b1595d5c@redhat.com>
Date:   Fri, 22 Apr 2022 17:47:02 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] fpga: altera-pr-ip: fix unsigned comparison with less
 than zero
Content-Language: en-US
To:     Moritz Fischer <mdf@kernel.org>
Cc:     Wu Hao <hao.wu@intel.com>, Xu Yilun <yilun.xu@intel.com>,
        Tom Rix <trix@redhat.com>, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220405185349.220607-1-marpagan@redhat.com>
 <Yl+K789ZUWd5Si0B@archbook>
From:   Marco Pagani <marpagan@redhat.com>
In-Reply-To: <Yl+K789ZUWd5Si0B@archbook>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022-04-20 06:24, Moritz Fischer wrote:
> Marco,
> 
> On Tue, Apr 05, 2022 at 08:53:49PM +0200, Marco Pagani wrote:
>> Fix the "comparison with less than zero" warning reported by
>> cppcheck for the unsigned (size_t) parameter "count" of the
>> "alt_pr_fpga_write()" function.
>>
> Should this have a Reported-by: tag?

I found this problem using the "cppcheck" tool, as reported in the
commit log. I did not find any previous report of this. Am I missing
something?

>> Signed-off-by: Marco Pagani <marpagan@redhat.com>
>> ---
>>  drivers/fpga/altera-pr-ip-core.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/altera-pr-ip-core.c b/drivers/fpga/altera-pr-ip-core.c
>> index be0667968d33..2ff3d8e46a0c 100644
>> --- a/drivers/fpga/altera-pr-ip-core.c
>> +++ b/drivers/fpga/altera-pr-ip-core.c
>> @@ -108,7 +108,7 @@ static int alt_pr_fpga_write(struct fpga_manager *mgr, const char *buf,
>>  	u32 *buffer_32 = (u32 *)buf;
>>  	size_t i = 0;
>>  
>> -	if (count <= 0)
>> +	if (count == 0)
>>  		return -EINVAL;
> 
> if (!count)
> 	return -EINVAL?

Ok, I'll change that in v2.

>>  
>>  	/* Write out the complete 32-bit chunks */
>> -- 
>> 2.35.1
> 
> Cheers,
> Moritz
>>
> 

Cheers,
Marco