Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Yihao Han <hanyihao@vivo.com>
To:     Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Cornelia Huck <cohuck@redhat.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Stefan Richter <stefanr@s5r6.in-berlin.de>,
        =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>,
        Corentin Labbe <clabbe@baylibre.com>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH v2] macintosh: macio_asic: fix resource_size.cocci warnings
Date:   Thu, 21 Apr 2022 07:18:07 -0700
Message-Id: <20220421141821.11519-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UFZ6vpgCKJ7vU0WS09OMMXYSK9YgWRdx+29ypMZS5aG8Ul6t4mnmtJFRTNWZ?=
 =?us-ascii?Q?s4Lw7pLEIgY3W8ADhZJvIejPDOx2wLSjqwVmcyA8ec0AMz3uSApeAk6SJ6t1?=
 =?us-ascii?Q?z1sXyZOuW4+ywbEfsIb8SYlWIAFAz/ElHUYWMfVoToWF6R67ERly0Mw0b7SC?=
 =?us-ascii?Q?SU6PUYDPjeQ+eN2be9JnN4cOrX6jNoDoJkNIoZWTuLUynLB/GOEGplGVdL5Q?=
 =?us-ascii?Q?mcfWqzav2CZy/YaGAFeL9mtlUXfNM2irvaO+6xo+KgxbTduuRiRT8tNNAhGr?=
 =?us-ascii?Q?Bry0yr1gFJ6L9ATS3QgogCtyUvJBh5YCTCejiuD4shZdCx/f6k+lysIW9aPz?=
 =?us-ascii?Q?kUUCrcMIOYxO+jeyK6woJlygqdYv0Kt2Jl9iwA3pNxeQcWmOCgkmXbQIAdln?=
 =?us-ascii?Q?knXUklx2yFsOwrnil9G/STN2acJY1aZbSkdktRnUFeGb95PSJ2V2W7ypR6Wb?=
 =?us-ascii?Q?H7j7WrWR9Ij/npIO55MtFFWhF/VD3QS1a5uUJvwKeKJLIe/Ih0Hox3j/fDZr?=
 =?us-ascii?Q?1O5G+KziqmEtzajw1SkerLdLvP348/gogJi28Qnmm9Eqtxy1L8Y7lCccQfmB?=
 =?us-ascii?Q?FLYJkqC3tI4Kaam+BZSOb8YaHpNedUte0WrxAOND9rWRc2rcbkE2E5ZBgx2H?=
 =?us-ascii?Q?CDUztdr1CLK0C0htIlET6/pBaBxpyTfjfSqnPrNS9yZ/cNgnLYDDjNvssitU?=
 =?us-ascii?Q?aYtVNAA2q9hi3qLtL26r8tkv3NY64K7EfBHAKiCy1UM4hoNjTCqUx5JIp0SR?=
 =?us-ascii?Q?X4ULwy0rxfxzQTiDrAXdhl59q/85APFT0m2CQq/tI9AxwaJhCXD1A2ZdTxam?=
 =?us-ascii?Q?GwpLuHVYlwfaD8dwWv9ToAbJrCsm+liLVLPaTMQKg88pA8ArOHaYcZuXkang?=
 =?us-ascii?Q?IIEnzyH9R7XmX58EXD8gWtt42Kvmudes7VqqeUVed7PBVlwnDTxqaRioVuiW?=
 =?us-ascii?Q?4ocxHZt0v9KuxEV0Jn0cXHeXWRkF8NWq2FpjdZUy4Hfg3ByjY41XSaxYYU1K?=
 =?us-ascii?Q?nHaFPQvB/tcsxxD49axLlYoqVSD4qxlcKweptGnSPpSgbTJFsQZ3Zh6q6bAu?=
 =?us-ascii?Q?014JklFknm7Ela2wphtRYM4gUrDsZGYiIqCwXrPLOM+nWyGcaFB3sccnwF+d?=
 =?us-ascii?Q?gfW8onPnV8i2GAKfXZWcslsUsCCd692DiKe0wZHhReb4pq+qgaEiCYAy1I3F?=
 =?us-ascii?Q?Bu5oC1YBhF3bbkBvXjKtKFK6heRJGzWaE4BDUmFV2b3Yq/dAJm9jhZ126M73?=
 =?us-ascii?Q?q06e3ZViq3Ex6QlInCxdVEHUg3LsDI7M+X/vGBZbR1dN4Ry5OOKwIW8BtMEI?=
 =?us-ascii?Q?wuTxI6VpRyNVgU3OkzkFmt2qiWfLF3pZ+lXFagLtwhWvmrEY8Ao4rikx/hHM?=
 =?us-ascii?Q?DlGrrojyk7DgVZ4FDomS1kBYZcr86wQwtryCUcUJi40m+UYuK4oup/w6pMEg?=
 =?us-ascii?Q?nI8S2m3nPdooEMnTti05Mp309znaO3O+mLMOzzT4iojFQ3wpje81nJeICWM9?=
 =?us-ascii?Q?258yZiLKj493MbdGa0FCPGv2QVjsrWdKvyqf+1WjSqOzHQEi9QVeyv0akLBW?=
 =?us-ascii?Q?p38X6vAueh3Fa1+lrS01WdRDCuCLyPRSOzcXd0xUbudS4AfbzGAIA4PJffmO?=
 =?us-ascii?Q?jWj54iSLbc1H/5kt4ELjNMdTKKWr0b5PQfH64+befw/Ut1yTCjSkm1N1/whY?=
 =?us-ascii?Q?fSQt1HwemT6FAwV3dhb2FSdGNgxbU1Dng9fq4oPP0LaGwuhlEMVcATwy2Ck9?=
 =?us-ascii?Q?9H2hmQ72ZA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 890f61ec-dc2a-4d55-2600-08da23a1d639
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2022 14:18:41.8685
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4CaJySsynSHw0ZdEVxijAgNiXMgA9gChu7C0t3M7FhrUtI1xecz9aGIEmw7b0XTQRz/unq3yTPgarP0jeHhqIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0PR06MB2163
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

drivers/macintosh/macio_asic.c:219:26-29: WARNING:Suspicious code. resource_size is maybe missing with res
drivers/macintosh/macio_asic.c:221:26-29: WARNING:Suspicious code. resource_size is maybe missing with res

Use resource_size function on resource object instead of
explicit computation.

Generated by: scripts/coccinelle/api/resource_size.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
v2: drop parenthesis around resource_size(res) and edit commit message
---
 drivers/macintosh/macio_asic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
index 1943a007e2d5..260fccb3863e 100644
--- a/drivers/macintosh/macio_asic.c
+++ b/drivers/macintosh/macio_asic.c
@@ -216,9 +216,9 @@ static int macio_resource_quirks(struct device_node *np, struct resource *res,
 	/* Some older IDE resources have bogus sizes */
 	if (of_node_name_eq(np, "IDE") || of_node_name_eq(np, "ATA") ||
 	    of_node_is_type(np, "ide") || of_node_is_type(np, "ata")) {
-		if (index == 0 && (res->end - res->start) > 0xfff)
+		if (index == 0 && resource_size(res) > 0xfff)
 			res->end = res->start + 0xfff;
-		if (index == 1 && (res->end - res->start) > 0xff)
+		if (index == 1 && resource_size(res) > 0xff)
 			res->end = res->start + 0xff;
 	}
 	return 0;
-- 
2.17.1