Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp846983pxb; Fri, 22 Apr 2022 12:28:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzk6N85HpjrBqijvhIwL+u+Jh9M9Orlmb4BR1GzlUm9YsD6IHrh57keojk61B6rsxZ0HuGL X-Received: by 2002:a17:902:e94e:b0:15b:22a7:f593 with SMTP id b14-20020a170902e94e00b0015b22a7f593mr5990784pll.148.1650655724464; Fri, 22 Apr 2022 12:28:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650655724; cv=none; d=google.com; s=arc-20160816; b=C1MKN1Ym6Dl29yCRsCv3vGsONUaLEJiWbswxrBWwqSMy7BVjiH9PCCFCVvIWk6/fFR oCItRQl4eJW5Fx96l8sXgEmuNPLvfBu+9rYmlKg+3KVapcyCUtb45Fgr2vaPMLhAYrAd wSfLRsTATR6PcdoaLS2fKhU/5Rsbq6r6+APFftS8fh8x1jtt5Q9dw8c1deTLGk7QUbf4 r0aI4h/ntlFtQ6dpd+mXfo/2deg7i3u2LvnM9HmsXyuZCrHirAFSi3jtiqVEjiI2bOXg UoMCqQVwBKg5E8kmb7FddAqfNuPiefmEm/h3aOqZdJXpm3407jNv8mXYrlLS1lHHtUTT 2IoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=uBe+1cUaX06F3zI/+9m15S2W79Zc/DobrqA4zpkLk00=; b=VgZ24MbcoMqg3mMmkikVeARr79MdghXf45V0/JnIuIPeZ3o9rDhKq7EmBhADmwYPom rGZB18Ukw6g4T18iQwhxxWzHjmszRSl99HFb/ZGdBvDSbHbWgEIQvYIGc6XcfbmMI35i 6rSElae1I5zWuUv83CtpZbKugz8fq0He9AmD1FWrdCowY2rVvmSu8dr+LuidXI43BbOY 6gHCNd78lMqBa0cap8zJ8bonpBM8LsR1Br/TPY3a4fyVQLfTajXFMY0/zUH7ssIcEkVn DhC9NyyCy3IPnl/PvGaIYhD9UTfF5pLjZ6t3jK00n57d12FccGx1tGe6wcpSZZdZbRjE caww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=krbaVWV9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id v63-20020a638942000000b003aa88e759e5si6131702pgd.395.2022.04.22.12.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 12:28:44 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=krbaVWV9; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 31A621240F8; Fri, 22 Apr 2022 11:39:05 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1390355AbiDUP7g (ORCPT + 99 others); Thu, 21 Apr 2022 11:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1390357AbiDUP71 (ORCPT ); Thu, 21 Apr 2022 11:59:27 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2EFB042A20; Thu, 21 Apr 2022 08:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650556590; x=1682092590; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=uBe+1cUaX06F3zI/+9m15S2W79Zc/DobrqA4zpkLk00=; b=krbaVWV9PS6zAFKucOvAgbA7zzG/iXImo1Heh4ZBm6v9/anQF31VhARx 9KhVj5b3hnmNhqHctgkTLADoF6S4t+FOStu8AJvgbpVvKAA9s4TFuqict WUlWh66jeyKJHEdaupAPuhmtZ48tZhcvaEBHNZbDGN/seTiWFPKORtKcP s=; Received: from ironmsg09-lv.qualcomm.com ([10.47.202.153]) by alexa-out.qualcomm.com with ESMTP; 21 Apr 2022 08:56:30 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg09-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 21 Apr 2022 08:56:29 -0700 X-QCInternal: smtphost Received: from hu-vnivarth-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.111.166]) by ironmsg02-blr.qualcomm.com with ESMTP; 21 Apr 2022 21:26:13 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id DAE193C82; Thu, 21 Apr 2022 21:26:11 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, Vijaya Krishna Nivarthi Subject: [V6 1/2] arm64: dts: qcom: sc7280-idp: Configure CTS pin to bias-bus-hold for bluetooth Date: Thu, 21 Apr 2022 21:26:06 +0530 Message-Id: <1650556567-4995-2-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1650556567-4995-1-git-send-email-quic_vnivarth@quicinc.com> References: <1650556567-4995-1-git-send-email-quic_vnivarth@quicinc.com> X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change active and sleep pinctrl configurations to handle same. Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson --- v6: add code comments about how bias-bus-hold could save power v5: modify subject to include bluetooth v4: modify subject of patch to indicate file it is applying to v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 015a347..6c2aab6 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -400,10 +400,13 @@ &qup_uart7_cts { /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power + * usage when Bluetooth is turned off. Bus hold will + * maintain a low power state regardless of whether + * the Bluetooth module drives the pin in either + * direction or leaves the pin fully unpowered. */ - bias-pull-down; + bias-bus-hold; }; &qup_uart7_rts { @@ -495,10 +498,13 @@ pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power + * usage when Bluetooth is turned off. Bus hold will + * maintain a low power state regardless of whether + * the Bluetooth module drives the pin in either + * direction or leaves the pin fully unpowered. */ - bias-pull-down; + bias-bus-hold; }; qup_uart7_sleep_rts: qup-uart7-sleep-rts { -- Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by the Linux Foundation.