Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp850127pxb; Fri, 22 Apr 2022 12:33:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3N4f8gmNw1GstWmqFtb0YWlvtMHGDxh5oBkR28tlzvT1UmK+l/DZ6Q7r9HcwT/Vjjc2cd X-Received: by 2002:a63:fd07:0:b0:3aa:1cd9:194f with SMTP id d7-20020a63fd07000000b003aa1cd9194fmr5191568pgh.509.1650656009480; Fri, 22 Apr 2022 12:33:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650656009; cv=none; d=google.com; s=arc-20160816; b=PHBzG2OCWb2q8wQWTNG5P4BoDjIcfoUB84NB/vOI6GbEYPAyIFQSaR7C7q++yhbYDr wx5kkh3Z2GztqdWxO9BZaYTWJU1YQkg/ka9vNjQWAWtcleeg9pyCdGWpInOFC2HDPoxe qDg37X5blwfcpc8EWlGvc0w3HibLlJGGOlHkL4sVjD8spzXKA9bYuTaNkd/YOkgn28aq ++nvArzYzMNH7W7lueRG55HEI1ACsk3v1SCLqNdmCuTjktMtatPdoXmsTGbuhrzV07yy BZ1NfDNeqiX9iFRi+0bvdrPNnqXmkSsPM6p3umlekYK93wimx7WXloJ56PSbCvR3ubFh /rzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=MxJHw28C4/w5oPPJ1p9TwDu24nHEiMgLTb0Gil3QA9g=; b=OCT4bVPPLnQMUqIEpYslJ/GhvrzFyowXm7jY5f06lk0jdNm0PvEXBUfZQ5YwUNWl0v KpSmPPk2XRgm1MHJy9m64H3Zu0P5hIGuvo7v82Nn2seClxYZnY7t3yIeY/wzVItDyTfJ 8+mrE2RKUUNLW0ADTtQStSDBQquJUmBYiJ/82aTM7ZkmNB/+vjdbCJvq+xKjXh6rf/r5 4dt9PreuSm9lP9KAxTNpa4wlKytP4R4Ozr877SxT41UvYKClVz+8khy8lrdwVdtxEcHh xwUenua3FNzFDlMQFkCYwVjupn4kJgZhMTfWfQT6IMmlmPuXcQDtIc/ELIoZ2kxFf9m+ QmZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t6-20020a056a0021c600b0050a7c907890si9000123pfj.347.2022.04.22.12.33.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 12:33:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8AF2A1E7187; Fri, 22 Apr 2022 11:42:19 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1441867AbiDVGHB (ORCPT + 99 others); Fri, 22 Apr 2022 02:07:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379367AbiDVGHA (ORCPT ); Fri, 22 Apr 2022 02:07:00 -0400 Received: from mail.meizu.com (edge07.meizu.com [112.91.151.210]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A624FC7B for ; Thu, 21 Apr 2022 23:04:07 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail11.meizu.com (172.16.1.15) with Microsoft SMTP Server (TLS) id 14.3.487.0; Fri, 22 Apr 2022 14:04:01 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Fri, 22 Apr 2022 14:03:59 +0800 From: Haowen Bai To: Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter CC: Haowen Bai , , , Subject: [PATCH] drm/amdgpu: Remove useless kfree Date: Fri, 22 Apr 2022 14:03:57 +0800 Message-ID: <1650607437-22275-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org After alloc fail, we do not need to kfree. Signed-off-by: Haowen Bai --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index ec709997c9c7..5fb3e69c04c4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -1849,7 +1849,6 @@ static int amdgpu_ras_realloc_eh_data_space(struct amdgpu_device *adev, void *bps = kmalloc(align_space * sizeof(*data->bps), GFP_KERNEL); if (!bps) { - kfree(bps); return -ENOMEM; } -- 2.7.4