Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <95e1bd39-b159-f7a1-f51e-115dd0e60500@suse.com>
Date:   Wed, 20 Apr 2022 10:47:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH v2 0/2] USB: Quiesce interrupts across pm freeze
Content-Language: en-US
To:     Alan Stern <stern@rowland.harvard.edu>,
        Oliver Neukum <oneukum@suse.com>
CC:     Evan Green <evgreen@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Rajat Jain <rajatja@chromium.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Razvan Heghedus <heghedus.razvan@gmail.com>,
        Wei Ming Chen <jj251510319013@gmail.com>,
        Youngjin Jang <yj84.jang@samsung.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
References: <20220418210046.2060937-1-evgreen@chromium.org>
 <9f2752b5-8717-8ea3-1462-69bcfe42bb0e@suse.com>
 <Yl7Iz/lGk3fITzMK@rowland.harvard.edu>
 <8321b2c6-5bdb-2853-6812-50cd4e4d1bc7@suse.com>
 <Yl72GjATzVoJpSlA@rowland.harvard.edu>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <Yl72GjATzVoJpSlA@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VFQyiLAo3322/62rXHiLt2dOng+RAjgg7gf8bTrk5jFeGpEO15VmnZCQDC8E?=
 =?us-ascii?Q?ZYeYJ715HZH68ypdByfA0jzGfDj2y9ypQ4Q3WWEmSbPSd+zbKixk1K4oV+wW?=
 =?us-ascii?Q?D9DFKvXwQa8KnggLSVZsxZb5ngn/PvoYwma3xzN8hTK0fH7yIhE062JSDenj?=
 =?us-ascii?Q?myACeTCcl93lqhOxQ2wHbJylRvHHB9XpYbk8rU8PRFVbN4ZhxVoNf8htgBaw?=
 =?us-ascii?Q?0koHDsc8fnmaG9hTiAiww50Ed7Bl8PubNKxU/D7DrhaLcRUe+cZ53vIxnnx+?=
 =?us-ascii?Q?O6QYdbLZWcqAkcZ8nIkO2VD+zbC9/r5n1016Sh5JrykbMn1tA3cqD/oZm9LO?=
 =?us-ascii?Q?rDL5F94H/F15cDaa5YMDZ+oAma2ssf27zSeq02U9DUaIUjMiYwb/8o+ccLWG?=
 =?us-ascii?Q?887TOszV7dLd8Te6vxkZ1dVcfWWuUA3TMNNZplQqut49L1Y7MdtdQ5y9/pto?=
 =?us-ascii?Q?RRFewRZo5+DAGQQXIrK7lllTmFqq+LL566WqoA83meIPFpahAO7LXRYyIQnV?=
 =?us-ascii?Q?8zZYH8YjtIVnkILqCFoEzw0dc31A5AvXVL2RS5J43s06E5CqrGZkdI3ELyBA?=
 =?us-ascii?Q?XTxUqrKES2LR9Mr2uRH+wMvnW0u0WDYDeJprDeAqp6GsCaysHrFToKfKTJUZ?=
 =?us-ascii?Q?hxKZXj8PYk89tfrr6M4wAkmjFFy1whmymquMdO1snz6oI/Jne51EOthsATRx?=
 =?us-ascii?Q?RhjlNu/mvec5dK2xGWQf4ituRqoyHFa9uCVI2ZUDANG+Ho7vChAJQEY3/kAb?=
 =?us-ascii?Q?oAkyygvZrnX6Siw05XuzNfE0Pk6OWfNlTwyWcBH0M7QqRQ31UdLK2jE97wAN?=
 =?us-ascii?Q?zACPANI2bCLW4YnGLLfz9SEMBIFgRisNByp2P6vWTjWcW+AScwjmx0Yw+T7x?=
 =?us-ascii?Q?sL/FrMCFNuQ7KUbMLfNE7IdmXlzeczsX/YZz+ERSf2GlFJg7v/TGdkfFUOX2?=
 =?us-ascii?Q?OJY4lLoOJsXJ1SpiDOWlAXicTYbTEWCTo2wjoJU+KwWCOynnr3ekHzcd9YKC?=
 =?us-ascii?Q?EfTPb9KQYwRci6EKiloBtCLcBmV0FXLQjZlW7Le3lwXWGaCufgIxMotDcB2N?=
 =?us-ascii?Q?4SGUxyDOqI4Wcwvzs77UDIqsMAQHqXeT5pswtTtuArTNk8RQ1JyJiDXqshvk?=
 =?us-ascii?Q?ganfVm8JeSae2ab99zpspy8hSxaYd8vvzdLk8wOytT/dw/BlGL7q+avJq105?=
 =?us-ascii?Q?0lD1KNPDiQFfyrfkadoQDme4gMwreItptXzk3Sh5SwhqXQaVyGVlLoax3Y88?=
 =?us-ascii?Q?bnTx9WGo1cVMXN9dDQNUtfo6dLfXGJCcrkuV0HyqmJOVGGE9m53ZZOCv34g5?=
 =?us-ascii?Q?KBObM4flwo7CfYaG7rpGVnLEiPcZbjQzzf5CXruVzEZu7PpiYim5XJvDK+6e?=
 =?us-ascii?Q?hSegGx5gWazM/n1rLAaLn9G43KvGXgDPITrI5zBsKf25V/IUUJq4kBeghJ4u?=
 =?us-ascii?Q?4TdJ9dhyW0+1Mwt4l1DN1ZGvMVeQeAAv+0ew63kpjjYfeLIWEeDA+NDG3iIS?=
 =?us-ascii?Q?tOsTrRTKCOApsvzIHnVOxXzo8scWU7EwfglWnw6mdXydrwWa9rnfvJUmPRRU?=
 =?us-ascii?Q?4hRkNeodDUYmgfm+O2+mrWh9Kbc8DgeJwt5omoGvM+blx1tPH+bkDlukVVwz?=
 =?us-ascii?Q?JWuEP2FH1JvErLpJGrw9gqQApPXE+p+LKFw77aipLZ8hlYQSR5fXvrgMIpzz?=
 =?us-ascii?Q?bYexd4wpBUK+fO+nP1/HIZ5wdwVcsFzxWi9T05TdnrdQVVvkFqYHQuUylJ3s?=
 =?us-ascii?Q?E9pt9cmJMOutlvkN/363Jmp0oUqBF44jEZRh6SmlfYpsYUmunoFfKjFq43nO?=
X-MS-Exchange-AntiSpam-MessageData-1: gYBvb/ue+Pwg5Q==
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c1dc4d29-f343-4a7b-087b-08da22aa6784
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0401MB2526.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 08:47:30.5180
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wElMwABTH3s45VQif0m7eu9QDI2/kfT++430WtOdQiSxv4p2bCwsup0If5KJx/8I7Mt5DcdFBTYXigYmKOLfFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3417
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 19.04.22 19:49, Alan Stern wrote:
> On Tue, Apr 19, 2022 at 05:51:38PM +0200, Oliver Neukum wrote:
>>
>> On 19.04.22 16:35, Alan Stern wrote:
>>> On Tue, Apr 19, 2022 at 09:05:53AM +0200, Oliver Neukum wrote:
>>>
>>>
>>> The THAW part of suspend-to-hibernation is used only for writing the=20
>>> memory image to permanent storage.  I doubt that a malfunctioning HID=20
>>> device would interfere with this process.
>>>
>> True, if and only if all goes well. At the time thaw() has run writing
>> the image to disk can still fail. In that case the devices will still
>> be needed.
> Consider adding a mechanism to usbcore which would allow an interface=20
> driver to request that the next time its device is resumed, the core=20
> should perform a reset-resume.  Would that help?
>
>

Strictly speaking no. We already have that in form of the RESET_RESUME
quirk. The broken devices we are talking about here can do runtime PM
perfectly fine, if and only if remote wakeup is requested.
So we need that flag to translate only in freeze()/thaw() resulting in that
behavior, as opposed to every pair of suspend()/resume()

=C2=A0=C2=A0=C2=A0 Regards
=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Oliver