Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934465AbXEGRHx (ORCPT ); Mon, 7 May 2007 13:07:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S934438AbXEGRHu (ORCPT ); Mon, 7 May 2007 13:07:50 -0400 Received: from scrub.xs4all.nl ([194.109.195.176]:2739 "EHLO scrub.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934415AbXEGRHt (ORCPT ); Mon, 7 May 2007 13:07:49 -0400 Date: Mon, 7 May 2007 19:07:43 +0200 (CEST) From: Roman Zippel X-X-Sender: roman@scrub.home To: Krzysztof Halasa cc: Jeff Garzik , Russell King , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" In-Reply-To: Message-ID: References: <463F27CE.2040008@garzik.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 782 Lines: 25 Hi, On Mon, 7 May 2007, Krzysztof Halasa wrote: > Roman Zippel writes: > > > HDLC doesn't really look like simple library code, what's up with all the > > HDLC_* options? > > Sub-modules. So it's not simple library code, or is it? > Anyway, what does the patch "screw" exactly? Normal dependencies, you basically have to manually make sure they are correct (and it seems with your patch they aren't). Again, _please_ (with sugar on top) don't use select unless you have a good reason for it. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/