Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp853971pxb; Fri, 22 Apr 2022 12:40:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqGJNtId8Qk3/nersQX0Po1XKPuVhU4+mYNyFwX+/oTP8RM3vNpANBYIsxzdGKLp3AGId+ X-Received: by 2002:a63:6687:0:b0:3aa:193b:7a70 with SMTP id a129-20020a636687000000b003aa193b7a70mr5233914pgc.493.1650656413874; Fri, 22 Apr 2022 12:40:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650656413; cv=none; d=google.com; s=arc-20160816; b=xybOvNWZRxtvKi25/unGj/wBwx63UCrn2lctBqrDJmvK2hQv44d50PseW6StjoAEmj iPkfoXxpAjrfHiis5lAfApGMNfUYxzsWX2zCMcLQQbD7BMu68Fk52R6arVD39Po03G/g drFHbn0RTCZDAJHMq1FEeVgSNXRrl3vAuAVjnpMYV+ShyRYH0h4E9k+uI3lG08WHftyx H3bL0mBAQog/hVHB8ov9cNe5kCo1JS2kq4wxOs4KthQlJ04iTPSuWKHZ5p3RdMwjnjY9 ZMLZlns0J6HsSHKVFPSQy4S7vHu/6DhzIKl+lNuz/r5H7pTUwTy1jbuwKOM3tHwQ3wWn QW+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iA+jGKClUvGezMDT1VSqteR5fgKxe0MYow2rzFPqCCc=; b=R5CEb4ZjRBPs8R6unmtO4y5NqzP8YL+XBs7cK8tRTfeAkylmOMavpR6JEGCpb7XNM7 bBxmo07yuX2DS1rMQ8gcSGLSE0gpjZi1fEmklarP/h86p5RRK5IoLSTfw912CBcpLz81 Q11D8UoAfoY5uJvLVYli4oaaqOGBQfxhWjlHXtYUsPz2yGqnnyNjJ2xU53lAFWEY9IH1 gLmcv3FePBxKbVZLHrqYzXqT0DghvXupintIICTDnd3bV9qNU2dkZzyc6hIkZHdHOFHe LpMmVEFAmvJj2Kf7g4qw1qeLkiU928iMKuKt0qQNafIg1A15sTjjEG+6QydXg14HzYRD 2Uyw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j18-20020a170902da9200b00158f817a251si9692754plx.180.2022.04.22.12.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 12:40:13 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1E2331FACEE; Fri, 22 Apr 2022 11:46:13 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1447567AbiDVMf1 (ORCPT + 99 others); Fri, 22 Apr 2022 08:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1447563AbiDVMfZ (ORCPT ); Fri, 22 Apr 2022 08:35:25 -0400 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7341F57151; Fri, 22 Apr 2022 05:32:32 -0700 (PDT) Received: by mail-qk1-f180.google.com with SMTP id a186so5656140qkc.10; Fri, 22 Apr 2022 05:32:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iA+jGKClUvGezMDT1VSqteR5fgKxe0MYow2rzFPqCCc=; b=oO8pckqikathwL0cJwEOjVERO0Mm9ID6Nvgs+0z2sDLlWvUnZcbkpLCv2AWddXMckn iF//lPYc/6XOoipoPnz5/jTbc9tTgOYeohiCubo/DX25CRDEH7ypZyMnL6F31OwuUU6Q 1Xv+B/I/ucz8+ZDEkf3DZi00luoovfFwTNLmZ2oE1sibw8IUO4EX1u2Wfu7WicCVXO3p s+ccKDbdwB43B2z5sRt5eze5e6mHExkCknGdGuSDzCoanzLloCVzzblri0N3OwLaN/R6 j3ss8IZQAvw1HRG5F8ibarZyL1tFQLMPGYtHGojjD8ttatN70Hi0L8DTtAxqU7pogPeV 0F9w== X-Gm-Message-State: AOAM530yuBTejDIau8qXT/isAjHCJySeaObGN/lULcgcEXcplSSQlD0w NZ8EtE+w34G88u/bVM9pO1w= X-Received: by 2002:a05:620a:469e:b0:69e:d1d8:6294 with SMTP id bq30-20020a05620a469e00b0069ed1d86294mr2521165qkb.36.1650630751116; Fri, 22 Apr 2022 05:32:31 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-008.fbsv.net. [2a03:2880:20ff:8::face:b00c]) by smtp.gmail.com with ESMTPSA id s136-20020a37a98e000000b0069f0c30c0d3sm858000qke.21.2022.04.22.05.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 05:32:30 -0700 (PDT) Date: Fri, 22 Apr 2022 05:32:27 -0700 From: David Vernet To: Tejun Heo Cc: lizefan.x@bytedance.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 0/4] cgroup: Introduce cpu controller test suite Message-ID: <20220422123227.gtirbsygpjek3iss@dev0025.ash9.facebook.com> References: <20220419213244.2104972-1-void@manifault.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20211029 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tejun, On Thu, Apr 21, 2022 at 12:21:18PM -1000, Tejun Heo wrote: > * Can you please repost w/ Ingo and Peterz cc'd? Will do, I'll cc them on v2. > * Maybe cpucg instead of cgcpu? Agreed, that seems more intuitive. I'll change it in v2. > * Single level testing is great but extending the case to cover deeper > nesting level would be great. ie. a test case with multi level tree w/ > both under and over provisioned parts in the tree. This sounds like a great idea. I have another patch set that I was planning to send out which adds a few more testcases. I can include some testcases in that set which validate more complicated nesting setups. Thanks, David