Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 20 Apr 2022 10:42:49 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Cc:     linux-media@vger.kernel.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzk+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v3 3/4] staging: media: Add support for the Allwinner A31
 ISP
Message-ID: <20220420074249.GB2951@kadam>
References: <20220415153708.637804-1-paul.kocialkowski@bootlin.com>
 <20220415153708.637804-4-paul.kocialkowski@bootlin.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220415153708.637804-4-paul.kocialkowski@bootlin.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+zcdLF4yOoPQGv8/qHAcnirnWOK40lKVf7RqqjGg2xyV7KOjQGLAwtVNs6bQ?=
 =?us-ascii?Q?cAmtIbx0+Rz5eJMIzLDn6ydvBfl4pM41ELACVzanpbzr0skbDNduC71iLkaV?=
 =?us-ascii?Q?To4Z+puZWlkve6OGQkWFKdQF/N2Q2z6P/bIG5TelV4+RlhiWH5XKPWltq9VR?=
 =?us-ascii?Q?aNPQpNY7Lgq1sbaxV2014OGgDuObqrH7RJs3iigigH5G8xAP1FDBwhpzLK6E?=
 =?us-ascii?Q?zZygBKaXidLnhKmiUq5ps4H6CKDl3AGwX0JzlGPdDf12ODBPDT+jS+w/JLn0?=
 =?us-ascii?Q?EV90B09ZAB/evS9zdXJ5s0DVBqPw7i6dMvB8utvQZq2MsI2fgyc10ljAdVxi?=
 =?us-ascii?Q?yYsZ4YUwQdj2pYj6/HAg+PPuJKYbSWtIvU+sbRdqfktT5dtcNnOwCshiuOb8?=
 =?us-ascii?Q?61HYr6H4lW+rLE28emwleC8neM0KB5kQTrYCK9dUjaCbjhP5N+fPkMdrkpUL?=
 =?us-ascii?Q?/8g+oi0UMGVhkVlFxAapJP7GNqCXlFlfFQaYS4yviJBP/4naOqTqkJ3j2O5s?=
 =?us-ascii?Q?TIF7jJ8QBQQTFLpMRn4u25GBN69iOeVI0Ck7w7f+qa7tI2myUiTrrLtV/qnZ?=
 =?us-ascii?Q?v85nsmLae6nDTMs0bw7escp7zFW2Z9cKGUoboWSxtWciIFI4Debn2u32O0lu?=
 =?us-ascii?Q?Hb2rU7s6nyVDokxpozDuuNdxv48hWu7SG3U1D0eot/XE3rJWrJcruM/d/Jwl?=
 =?us-ascii?Q?6V1P1EBf2Z7vfeBKIyZ86mP9SgFw0sRAdJem1jcy4t3xwda7oacr5OqhDGyX?=
 =?us-ascii?Q?PIcBhwcBhpK4fK8Um9+28ed9KP4LQMWQWregDRk1aW4tstrapMecVJXAqiJG?=
 =?us-ascii?Q?XYU/aJ+xCeb16pJqOXsqmdv6qIoaFZllZyScP0s/h6bpuUpozlQ7T3vqmduP?=
 =?us-ascii?Q?nLKuYlgeVMDeQvoS37X6NvRtWZom7bcFFC8kvn+phHxg97PbKQK6KJid1m4O?=
 =?us-ascii?Q?E8mkQaqcqopxjd45WwGnVnqVSzv3ZSfWTKV5fvP73brkVL6Pc67f6NFgpKD0?=
 =?us-ascii?Q?84Q9PNcQuXjZ3a2l+WW8nazhw5W8MxzRC6gTg5GGoDq5v0DxDbczrYWXsbcO?=
 =?us-ascii?Q?O921OKUNusxzENfdNwtudg1z/eXDEIYQYLvduXoUpnMBQ90zsdALTjVGHI5B?=
 =?us-ascii?Q?IlgVp3G3GhskPebJMfXsWwot4MMouEDWiy8SF6+giNKNz3WRV98I9aPmiNe5?=
 =?us-ascii?Q?s1BgV/mZHFY57zqI2YMoBSpS2lncK44up5PdYzpYEhoGhoYyLYYOslOGOdsV?=
 =?us-ascii?Q?TU89qtI1ubL6a9Qot8unOx5vnnekhWl9tVYf0oujchqu/IIqPGohVFm2QkLU?=
 =?us-ascii?Q?3q82oDgbDvGTRLz1Mzc2Jn/sYgw05E9RMWzQ54WGX2LJoUrOO+a7kQTW5GXs?=
 =?us-ascii?Q?AsDDwdMreVcp+/JTU/PCjhRpvPXndsEK+N6ROScs0q6ffZ8t7ajO4snGkTcI?=
 =?us-ascii?Q?4+ENm/yUntJZ7VtbsloiaYiZ+sQngam0GlF0hVFb7YAy7N+AmbZhdhYnjp2r?=
 =?us-ascii?Q?ckYNgAsicZ5mykfS3UKJFyL8+G7os/bnerYBmm3z14JVCcQ3wcCXnNb6pTt+?=
 =?us-ascii?Q?GqW9zBseEuMUdjI0bN5bh8hlx7YSxZXPjJiwdbNbPCQ1sOeIPmlLvz89SzQU?=
 =?us-ascii?Q?f7mPvNuslj5jWE2lUl+mPYBrXJrjy7UJdjZtxKrxH62ZyZwnSwwcnbh2j8IS?=
 =?us-ascii?Q?4OwVYoul7APW9bXWzM+NcZtJhtRBErHVrpd1Tl//VsRv+3qomRxMAyM8B4e5?=
 =?us-ascii?Q?8j1Z3WMUNnfdDLzEjJibLwCvCGBcAbo=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 42d91fe1-f19d-4009-5dbb-08da22a17040
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Apr 2022 07:43:19.7035
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cSjBW7UCHsdaC8U6pJYeIgb8zHMncWP1kZVbZ9gOVvLxbBJGb92eO7nUcdk285d46qZHflYiOM1Hk1c4npqWbI6BQzWtM22cLgYrsQO9JSU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1975
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-19_08:2022-04-15,2022-04-19 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxscore=0
 adultscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204200046
X-Proofpoint-ORIG-GUID: vzQMH6nk699W_YeTFs1gGyYZTXd2VxQ2
X-Proofpoint-GUID: vzQMH6nk699W_YeTFs1gGyYZTXd2VxQ2
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I ran Smatch on this patch.

On Fri, Apr 15, 2022 at 05:37:07PM +0200, Paul Kocialkowski wrote:
> +void sun6i_isp_capture_configure(struct sun6i_isp_device *isp_dev)
> +{
> +	unsigned int width, height;
> +	unsigned int stride_luma, stride_chroma = 0;
> +	unsigned int stride_luma_div4, stride_chroma_div4;
> +	const struct sun6i_isp_capture_format *format;
> +	const struct v4l2_format_info *info;
> +	u32 pixelformat;
> +
> +	sun6i_isp_capture_dimensions(isp_dev, &width, &height);
> +	sun6i_isp_capture_format(isp_dev, &pixelformat);
> +
> +	format = sun6i_isp_capture_format_find(pixelformat);
> +	if (WARN_ON(!format))
> +		return;
> +
> +	sun6i_isp_load_write(isp_dev, SUN6I_ISP_MCH_SIZE_CFG_REG,
> +			     SUN6I_ISP_MCH_SIZE_CFG_WIDTH(width) |
> +			     SUN6I_ISP_MCH_SIZE_CFG_HEIGHT(height));
> +
> +	info = v4l2_format_info(pixelformat);
> +	if (WARN_ON(!info))
> +		return;
> +
> +	stride_luma = width * info->bpp[0];
> +	stride_luma_div4 = DIV_ROUND_UP(stride_luma, 4);
> +
> +	if (info->comp_planes > 1) {
> +		stride_chroma = width * info->bpp[1] / info->hdiv;
> +		stride_chroma_div4 = DIV_ROUND_UP(stride_chroma, 4);

stride_chroma_div4 is not intialized on the else path.

> +	}
> +
> +	sun6i_isp_load_write(isp_dev, SUN6I_ISP_MCH_CFG_REG,
> +			     SUN6I_ISP_MCH_CFG_EN |
> +			     SUN6I_ISP_MCH_CFG_OUTPUT_FMT(format->output_format) |
> +			     SUN6I_ISP_MCH_CFG_STRIDE_Y_DIV4(stride_luma_div4) |
> +			     SUN6I_ISP_MCH_CFG_STRIDE_UV_DIV4(stride_chroma_div4));
> +}

[ snip ]

> +void sun6i_isp_params_configure(struct sun6i_isp_device *isp_dev)
> +{
> +	struct sun6i_isp_params_state *state = &isp_dev->params.state;
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&state->lock, flags);
> +
> +	sun6i_isp_params_configure_base(isp_dev);
> +
> +	/* Default config is only applied at the very first stream start. */
> +	if (state->configured)
> +		goto complete;
> +
> +	 sun6i_isp_params_configure_modules(isp_dev,
        ^
There is an extra space character here.

> +					    &sun6i_isp_params_config_default);
> +
> +	state->configured = true;
> +
> +complete:
> +	spin_unlock_irqrestore(&state->lock, flags);
> +}

regards,
dan carpenter