Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220421090313.24864-1-linmq006@gmail.com>
In-Reply-To: <20220421090313.24864-1-linmq006@gmail.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Thu, 21 Apr 2022 10:22:02 -0400
Message-ID: <CADnq5_PawNQThkhwMW4=GY4TOn1DLsvG_zUONYwf0WtGx0i8GA@mail.gmail.com>
Subject: Re: [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Harry Wentland <harry.wentland@amd.com>,
        Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Laktyushkin Dmytro <dmytro.laktyushkin@amd.com>,
        Solomon Chiu <solomon.chiu@amd.com>,
        Stylon Wang <stylon.wang@amd.com>,
        Victor Lu <victorchengchi.lu@amd.com>,
        Ilya Bakoulin <Ilya.Bakoulin@amd.com>,
        Melissa Wen <mwen@igalia.com>, Angus Wang <angus.wang@amd.com>,
        Fangzhi Zuo <Jerry.Zuo@amd.com>,
        Isabella Basso <isabbasso@riseup.net>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Applied.  Thanks!

Alex

On Thu, Apr 21, 2022 at 5:03 AM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> When dcn20_clk_src_construct() fails, we need to release clk_src.
>
> Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 3fe4bfbb98a0..faab59508d82 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -997,6 +997,7 @@ static struct clock_source *dcn21_clock_source_create(
>                 return &clk_src->base;
>         }
>
> +       kfree(clk_src);
>         BREAK_TO_DEBUGGER();
>         return NULL;
>  }
> --
> 2.17.1
>