Received: by 2002:a05:6a10:6d10:0:0:0:0 with SMTP id gq16csp855555pxb; Fri, 22 Apr 2022 12:43:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJV3vrTOEISHC2ZK714yTLqHogVuvCkiXjGlVj4ftZeNbWLCyPJ+0ZEjP4M+XDLf7F8nkw X-Received: by 2002:a17:90a:4bc2:b0:1b8:cdd3:53e2 with SMTP id u2-20020a17090a4bc200b001b8cdd353e2mr17687828pjl.219.1650656581364; Fri, 22 Apr 2022 12:43:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1650656581; cv=none; d=google.com; s=arc-20160816; b=h9rFofvjvaot2jJbK37R2Cc54TQXxQghkTQYeLWVZmZCF/3ladiOP7EVX/xKZdPdE0 sal8L7V1bj9tOgdP9eA2NQixwpQ+ECexi+a83D68yBm0FxBmD1IwnBVm6xD55INqiJ4g 400LEjBESfBR2MvAZO0VqKIWVVKMVEVERBAZgF71M0nlPpwWeugt5zBP+dO6ZtPg3hmK Cn8b8Ndz9XgkEIrVNIuEGYWbUnLW3kHXsO0nbvBY3xEA1kmVQpkmphopJurNVkaNNQsL 9HxBs5oM/OVC1l39PDe3b4/ujXZ89U3vpRjjXncjVJJGThEGCHVRQp7ewAmAhrnasXNd GOkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=IXff8gL8fKrYXZG8etk6yFijPOFlrZnod0r01ih8NwI=; b=TIDVHZQELNiNVXVJNGS6ahp5cRrakzBEuaBv2L1cTxbgmyJD+hF/LfSf75LSrJnXR+ 8LCxSHXswem+RvQykP5cjaWMN1qZB+2Kw1RV0FNq7A/VaVQyuQHGopq+9vJ5bh8pJHAa owJGhK88g8zl6sonf25xe8j1ep5DVoMIi/R06OPMBPpsZq+6/bnq02jotApJVw9QZ08W Hn+q/ZCposlmuWFYiYQnPTMpCKuFFCtqyDSGSQyVlydYDYI7bahSG5tch/6rsg/vdRnx +VoA/Oq7m2oYNDRyixapSXeiekF6zvE9KkuYikraCKf9GDYxiCKJiwoo/HgKgfqx4kXJ Y5XA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id o3-20020a17090a5b0300b001cb7565298csi8083379pji.76.2022.04.22.12.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Apr 2022 12:43:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9C20F16E688; Fri, 22 Apr 2022 11:48:17 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1383845AbiDUCwn (ORCPT + 99 others); Wed, 20 Apr 2022 22:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1383832AbiDUCwm (ORCPT ); Wed, 20 Apr 2022 22:52:42 -0400 Received: from mail.meizu.com (edge05.meizu.com [157.122.146.251]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9A3DDEB7; Wed, 20 Apr 2022 19:49:53 -0700 (PDT) Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 21 Apr 2022 10:49:54 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Apr 2022 10:49:51 +0800 From: Haowen Bai To: Vinod Koul , Shawn Guo , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team CC: Haowen Bai , , , Subject: [PATCH] dmaengine: imx-sdma: Remove useless null check before call of_node_put() Date: Thu, 21 Apr 2022 10:49:50 +0800 Message-ID: <1650509390-26877-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to add null check before call of_node_put(), since the implementation of of_node_put() has done it. Signed-off-by: Haowen Bai --- drivers/dma/imx-sdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 6196a7b3956b..b8a1299b93f0 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1933,8 +1933,7 @@ static int sdma_event_remap(struct sdma_engine *sdma) } out: - if (gpr_np) - of_node_put(gpr_np); + of_node_put(gpr_np); return ret; } -- 2.7.4