Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 20 Apr 2022 11:31:29 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Alistair Popple <apopple@nvidia.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Nadav Amit <nadav.amit@gmail.com>
Subject: Re: [PATCH] mm/uffd: Move USERFAULTFD configs into mm/
Message-ID: <YmAnUQdQ63jD48ad@cmpxchg.org>
References: <20220420144823.35277-1-peterx@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220420144823.35277-1-peterx@redhat.com>
Precedence: bulk

On Wed, Apr 20, 2022 at 10:48:23AM -0400, Peter Xu wrote:
> We used to have USERFAULTFD configs stored in init/.  It makes sense as a
> start because that's the default place for storing syscall related configs.
> 
> However userfaultfd evolved a bit in the past few years and some more
> config options were added.  They're no longer related to syscalls and start
> to be not suitable to be kept in the init/ directory anymore, because
> they're pure mm concepts.
> 
> But it's not ideal either to keep the userfaultfd configs separate from
> each other.  Hence this patch moves the userfaultfd configs under init/ to
> be under mm/ so that we'll start to group all userfaultfd configs
> together.
> 
> We do have quite a few examples of syscall related configs that are not put
> under init/Kconfig: FTRACE_SYSCALLS, SWAP, FILE_LOCKING, MEMFD_CREATE..
> They all reside in the dir where they're more suitable for the concept. So
> it seems there's no restriction to keep the role of having syscall related
> CONFIG_* under init/ only.
> 
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Peter Xu <peterx@redhat.com>

Acked-by: Johannes Weiner <hannes@cmpxchg.org>