Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 07:44:42 +0800
From:   Solomon Tan <wjsota@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, Larry.Finger@lwfinger.net,
        phil@philpotter.co.uk
Subject: Re: [PATCH] staging: r8188eu: use in-kernel ieee channel
Message-ID: <YmHsannu/vcKX9Kk@ArchDesktop>
References: <20220421015811.2745-1-wjsota@gmail.com>
 <20220421170010.GD2462@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220421170010.GD2462@kadam>
Precedence: bulk

On Thu, Apr 21, 2022 at 08:00:10PM +0300, Dan Carpenter wrote:
> On Thu, Apr 21, 2022 at 09:58:12AM +0800, Solomon Tan wrote:
> > The rtw_ieee80211_channel structure just duplicates the in-kernel
> > ieee80211_channel structure
> 
> When you say that they are duplicates, I expected them to be the same
> but they're not at all.  ieee80211_channel has a bunch more struct
> members.
> 
> I don't really have a problem with the change necessarily but the commit
> message should not have mislead me.

Sorry about that. I will amend the commit message and send it as v2.
Thank you for the review.

> 
> regards,
> dan carpenter
> 

Cheers,
Solomon