Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Oleksandr Ocheretnyi <oocheret@cisco.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: fix 'part' field data corruption in mtd_info
Date:   Thu, 21 Apr 2022 09:35:33 +0200
Message-Id: <20220421073533.71758-1-miquel.raynal@bootlin.com>
In-Reply-To: <20220417184649.449289-1-oocheret@cisco.com>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 2022-04-17 at 18:46:47 UTC, Oleksandr Ocheretnyi wrote:
> Commit 46b5889cc2c5 ("mtd: implement proper partition handling")
> started using "mtd_get_master_ofs()" in mtd callbacks to determine
> memory offsets by means of 'part' field from mtd_info, what previously
> was smashed accessing 'master' field in the mtd_set_dev_defaults() method.
> That provides wrong offset what causes hardware access errors.
> 
> Just make 'part', 'master' as separate fields, rather than using
> union type to avoid 'part' data corruption when mtd_set_dev_defaults()
> is called.
> 
> Fixes: 46b5889cc2c5 ("mtd: implement proper partition handling")
> Signed-off-by: Oleksandr Ocheretnyi <oocheret@cisco.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel