Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966148AbXEGSQJ (ORCPT ); Mon, 7 May 2007 14:16:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S966092AbXEGSQD (ORCPT ); Mon, 7 May 2007 14:16:03 -0400 Received: from wr-out-0506.google.com ([64.233.184.230]:64800 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966055AbXEGSQA (ORCPT ); Mon, 7 May 2007 14:16:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=r8cW/P7cNMuTMy0ow0nQS+aMsEyFlJ9RFiaGmEc0Uj3wOBiZg4AcSDc+ftrzo+7Yv8mG+kQjacKh3W3+T6NQ/OgsLDRcN/URkQoLkPUEBZDnmzLrSwPeIAxl2Qg8imXUwiejd89iF+H5iR9yog0tLTicQP6LVeh0Y+PEwt0Qfkc= Message-ID: Date: Mon, 7 May 2007 23:45:58 +0530 From: "Satyam Sharma" To: "Roman Zippel" Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" Cc: "Krzysztof Halasa" , "Jeff Garzik" , "Russell King" , lkml , netdev@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <463F27CE.2040008@garzik.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1586 Lines: 38 On 5/7/07, Roman Zippel wrote: > Hi, > > On Mon, 7 May 2007, Krzysztof Halasa wrote: > > > Roman Zippel writes: > > > > > HDLC doesn't really look like simple library code, what's up with all the > > > HDLC_* options? > > > > Sub-modules. > > So it's not simple library code, or is it? > > > Anyway, what does the patch "screw" exactly? > > Normal dependencies, you basically have to manually make sure they are > correct (and it seems with your patch they aren't). Again, _please_ (with > sugar on top) don't use select unless you have a good reason for it. Yes, mixing select and depends is a recipe for build disasters. Call me a rabid fanatic, but I would in fact go as far as to say that this whole "select" thing in the Kconfig process is one big BUG, and not a feature. People are lazy by nature and would rather just "select" a dependency for their config option than burden users with several "depends". The following rant doesn't apply only to the select above, but unfortunately, that's precisely what happens when such stuff is introduced ... they seem like a good idea to the introducer for his special / rarest-of-rare case, but then others tend to {ab-,mis-}use it and the use of such primitives soon proliferates even to cases where they are clearly inapplicable / avoidable. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/