Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Sven Schnelle <svens@linux.ibm.com>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     <agordeev@linux.ibm.com>, <borntraeger@linux.ibm.com>,
        <gor@linux.ibm.com>, <hca@linux.ibm.com>, <hoeppner@linux.ibm.com>,
        <linux-kernel@vger.kernel.org>, <linux-s390@vger.kernel.org>,
        <sth@linux.ibm.com>
Subject: Re: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset
References: <yt9dilr539wq.fsf@linux.ibm.com>
        <1650348310-18553-1-git-send-email-baihaowen@meizu.com>
Date:   Wed, 20 Apr 2022 08:44:54 +0200
In-Reply-To: <1650348310-18553-1-git-send-email-baihaowen@meizu.com> (Haowen
        Bai's message of "Tue, 19 Apr 2022 14:05:10 +0800")
Message-ID: <yt9dy200xnh5.fsf@linux.ibm.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Haowen Bai <baihaowen@meizu.com> writes:

> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> V1->V2: also remove the isglobal assigment above, so the whole else block
> could go away
>
>  drivers/s390/block/dasd_eckd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 8410a25a65c1..6b70f9dfff02 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
>  {
>  	struct pe_handler_work_data *data;
>  
> -	data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> +	data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
>  	if (!data) {
>  		if (mutex_trylock(&dasd_pe_handler_mutex)) {
>  			data = pe_handler_worker;
> @@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
>  		} else {
>  			return -ENOMEM;
>  		}
> -	} else {
> -		memset(data, 0, sizeof(*data));
> -		data->isglobal = 0;
>  	}
>  	INIT_WORK(&data->worker, do_pe_handler_work);
>  	dasd_get_device(device);

Reviewed-by: Sven Schnelle <svens@linux.ibm.com>