Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1650607607-22893-1-git-send-email-baihaowen@meizu.com>
References: <1650607607-22893-1-git-send-email-baihaowen@meizu.com>
Subject: Re: [PATCH] media: m920x: Remove useless kfree
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     Haowen Bai <baihaowen@meizu.com>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
To:     Haowen Bai <baihaowen@meizu.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>
Date:   Fri, 22 Apr 2022 15:22:28 +0100
Message-ID: <165063734898.3204481.2637889109438003078@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Haowen Bai (2022-04-22 07:06:47)
> After alloc fail, we do not need to kfree.
>=20

Agreed, this shouldn't hurt as kfree will be a noop here but it is
always null so redundant.

May still warrant a fixes tag though, but it's not a critical fix.


Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  drivers/media/usb/dvb-usb/m920x.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/media/usb/dvb-usb/m920x.c b/drivers/media/usb/dvb-us=
b/m920x.c
> index 548199cd86f6..9df0ccfb654b 100644
> --- a/drivers/media/usb/dvb-usb/m920x.c
> +++ b/drivers/media/usb/dvb-usb/m920x.c
> @@ -277,7 +277,6 @@ static int m920x_i2c_xfer(struct i2c_adapter *adap, s=
truct i2c_msg msg[], int nu
>                         char *read =3D kmalloc(1, GFP_KERNEL);
>                         if (!read) {
>                                 ret =3D -ENOMEM;
> -                               kfree(read);
>                                 goto unlock;
>                         }
> =20
> --=20
> 2.7.4
>