Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 20 Apr 2022 19:31:45 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     =?utf-8?B?55m95rWp5paH?= <baihaowen@meizu.com>
Cc:     "sudeep.holla@arm.com" <sudeep.holla@arm.com>,
        "cristian.marussi@arm.com" <cristian.marussi@arm.com>,
        "ardb@kernel.org" <ardb@kernel.org>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] firmware: edd: Remove redundant condition
Message-ID: <YmBDgRYGdcjz3ppn@kroah.com>
References: <tjhedku0cwqypq8pujvusn6i.1647642604045@email.android.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <tjhedku0cwqypq8pujvusn6i.1647642604045@email.android.com>
Precedence: bulk

On Fri, Mar 18, 2022 at 10:33:12PM +0000, 白浩文 wrote:
> Dear Greg KH
> 
> But the logic here is:
>         (!A || (A && B))
> not:
>         (!A || A && B)
> 
> as you write
> 
> No, what I wrote is
> 
> the logic here is:
>         (!A || (A && B))
> Is the same:
>         (!A || B)

That is not what your changelog text says, and I quote:

> > The logic !A || A && B is equivalent to !A || B. so we have
> > to make code clear.

(note, top-posting is horrid and is why we do not do this, please fix
this in the future.)

So can you please fix up your changelog text to be correct and resend
it?

thanks,

greg k-h