Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 22 Apr 2022 17:44:23 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Tom Rix <trix@redhat.com>
Cc:     nsaenz@kernel.org, bcm-kernel-feedback-list@broadcom.com,
        gregkh@linuxfoundation.org, stefan.wahren@i2se.com,
        gascoar@gmail.com, ojaswin98@gmail.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vchiq_arm: change vchiq_platform_init from
 global to static
Message-ID: <20220422144423.GI2462@kadam>
References: <20220418164356.3532969-1-trix@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220418164356.3532969-1-trix@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?V1PDrrr9LZHWUmHmGU5BfvkX6HbyT20OMmRZWZwfvrJW3nN58IxBLjejRBi1?=
 =?us-ascii?Q?TGlncC/HIeAatrMmkn3swt2YbUtjnDvzDFi6AB1itI+eA54BdYR0a8bgzZj/?=
 =?us-ascii?Q?rgDJ2JWlFLQcr70EyQYV8Jwp1tFWUvR7Iu9LhEYSjfESUPEEUxCGKf8gGQFk?=
 =?us-ascii?Q?iJ5x6vZKzsEqOUSUPZzR9WMrjOSqoPzYgpHddZYXSqaEHcj2RoNLzoy0dDh6?=
 =?us-ascii?Q?Lfuknb7xYLpUG6TiKWfqrOPTz3YkxtW5QiIjRXNzczwBR8mJwG5ZOjx/Hd61?=
 =?us-ascii?Q?Xk3s8dR+wBiolM44ZrZ246BMonSg7q9x/Lb9K9zX6g227UjBo+7JQPu2AbNo?=
 =?us-ascii?Q?h6IR6ccOl7zsZs3Nx1MZpTrqcXhEjUbHw3MdGwfPfWrR98et/uxZYCd3J5fo?=
 =?us-ascii?Q?P0tCsAd0JL+vfx8OthFtml+7OXfj1rjtsCKRJPOBBR4+zc8/ZH5RaLhXMY+w?=
 =?us-ascii?Q?E4qXuDfX54xCvmr3jXwDKiSM2aFBTnCTEWf4YssSOBb9bsquZ/DATR3m2tO5?=
 =?us-ascii?Q?GW5brV+BVabez2S0lYx5TJ/Pom0cvBNbKHHq235518AGtar3C1VC6/PIELAf?=
 =?us-ascii?Q?9QLwpr7DYR0rx0qM8yitMK/gKBxE7PsontNv9cmBFyrqc3mJz3WOfDrmrC5T?=
 =?us-ascii?Q?T2q9RAVoIpL8N+wcMA7aBOTb6W3d4xNO5NeDjaCSrCTz1J+xsuI5antpVK8W?=
 =?us-ascii?Q?sYrWNxywam4bGY1PFG19cpzSDYWr1WuQPCykayje4OSWqfSiu0V7ibHn8PF0?=
 =?us-ascii?Q?ccJDgHK+0uuvoK8Wl+wPDAfcBec5No7moBExXAi7jOhIoqpccsEaRFWKlnNn?=
 =?us-ascii?Q?G2dIumIDuHkhC3Zitgrhi9IfNx0dosJt7xenI1o5OSw5jSbZA2X1fLWcfE6k?=
 =?us-ascii?Q?LXV/MycYgM79j4Ahw0Pl1gesfS2bMk7NfMkeeVzTxtpbRaSP5Ff1FIZGgqLP?=
 =?us-ascii?Q?swiEDNRLK+Am62i3hXesiI132xG8uMN+kYE8/mQ3ZpBP8ay9oKg1q96idQkI?=
 =?us-ascii?Q?B4jlMfXZPZYvbF70nj2L2mF2FKTkK2D+p8+2+MqzL3/vKZnRqYVzv+Dhql79?=
 =?us-ascii?Q?xEjTBIxK+rdOPiv+QPF51+T6+FKqAJcxdorg/4BcJ+JcFbA+capRnzI+ydDP?=
 =?us-ascii?Q?85XJ8dBIoe9dfSjfFYHwYbLlaTxDK15GJCK6OPmfThpmNtn/YXKvR559adqg?=
 =?us-ascii?Q?Dyc7MMCYpf9XMsznhd5Ql6n20jZUu0tK4hUhiMfeGnXzCwwRUQD3y9hDx+Ox?=
 =?us-ascii?Q?zIy3lBuT5PHClCGZRfVqOovIgMKIe3CqZWhF0kevq1dqYqoOcWEH0GpPOfRw?=
 =?us-ascii?Q?ffb2ZHEroWNSfxyjuH7Wk6axkD/Jkv7g8C4mtqTR/RVNXRIrIeOYfSJ2IPjl?=
 =?us-ascii?Q?5/WUQLyWUBfzdVnEnsIP/xL+Vr2UvZo6wND+Nl6jAG9d4K2YWHi0abb2x7IT?=
 =?us-ascii?Q?ADHZ+YFmWGK2vu49+0Ao07deYWC78d29Z4BsUvh24Wrt8TuKH49mHsvqdmSE?=
 =?us-ascii?Q?w82X3eko3l2AOk0sGsPyNlGrRajgtFZWqZHUjiTllo6Ww5njKk+9ixzOrNqe?=
 =?us-ascii?Q?BkloCbcBTbTFFqQyVOEpO1Yzbjfh+RuZJqKfFbBGLZgQEvQt6QgJRyI4gIMZ?=
 =?us-ascii?Q?+JRC8asqTIjOMPWUs/vTa0KVrv1fRTsdFG31mDSVm7AMf3pcMhBHWBGHFndn?=
 =?us-ascii?Q?/73EL2QgCWTGfjSSHkaLrN78Uz/synaTRX1PhslFES6O9TKXX8yf/kZsWmnx?=
 =?us-ascii?Q?nHs02Ea+dHxQcr1cwi6Y24KqyGqD50A=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 016c8cf1-537f-47a4-fb75-08da246ea511
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2022 14:44:46.4517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Tz3niUgGhva9YECVf/fINe2Xa+acWuBMKJI1KhGKgjHaM5UeJvCAm0tb9lPR6O8rl/ffCRucygv6X5kb423N5cJ9U2upMSc1wV6vWPVVfhI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2533
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-22_04:2022-04-22,2022-04-22 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxscore=0
 adultscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204220064
X-Proofpoint-GUID: 8J7B2fZdws4GtmXUNoSQxBLtivwMvMzI
X-Proofpoint-ORIG-GUID: 8J7B2fZdws4GtmXUNoSQxBLtivwMvMzI
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote:
> Smatch reports this issue
> vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init'
>   was not declared. Should it be static?

This is a Sparse warning, not Smatch.

Use this command for Smatch
~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

And this command for Sparse
~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

regards,
dan carpenter